Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(193)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1293053004: Remove grab-bag includes of v8.h from runtime entries. (Closed)

Created:
5 years, 4 months ago by Michael Starzinger
Modified:
5 years, 4 months ago
Reviewers:
titzer
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Remove grab-bag includes of v8.h from runtime entries. R=titzer@chromium.org Committed: https://crrev.com/d2168c2de6ed7bab577b889ab413b03a2ca4a274 Cr-Commit-Position: refs/heads/master@{#30232}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -68 lines) Patch
M src/json-parser.h View 1 chunk +4 lines, -0 lines 0 comments Download
M src/json-stringifier.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/runtime/runtime.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M src/runtime/runtime-array.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M src/runtime/runtime-atomics.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M src/runtime/runtime-classes.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M src/runtime/runtime-collections.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M src/runtime/runtime-compiler.cc View 2 chunks +1 line, -2 lines 0 comments Download
M src/runtime/runtime-date.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M src/runtime/runtime-debug.cc View 2 chunks +1 line, -2 lines 0 comments Download
M src/runtime/runtime-forin.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M src/runtime/runtime-function.cc View 2 chunks +1 line, -2 lines 0 comments Download
M src/runtime/runtime-futex.cc View 1 chunk +3 lines, -4 lines 0 comments Download
M src/runtime/runtime-generator.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M src/runtime/runtime-i18n.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M src/runtime/runtime-internal.cc View 2 chunks +1 line, -2 lines 0 comments Download
M src/runtime/runtime-json.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/runtime/runtime-literals.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/runtime/runtime-liveedit.cc View 2 chunks +1 line, -2 lines 0 comments Download
M src/runtime/runtime-maths.cc View 1 chunk +1 line, -3 lines 0 comments Download
M src/runtime/runtime-numbers.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/runtime/runtime-object.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/runtime/runtime-observe.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/runtime/runtime-proxy.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M src/runtime/runtime-regexp.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/runtime/runtime-scopes.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/runtime/runtime-simd.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M src/runtime/runtime-strings.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/runtime/runtime-symbol.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/runtime/runtime-test.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/runtime/runtime-typedarray.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M src/runtime/runtime-uri.cc View 1 chunk +2 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Michael Starzinger
5 years, 4 months ago (2015-08-18 17:14:27 UTC) #1
titzer
lgtm
5 years, 4 months ago (2015-08-18 17:16:07 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1293053004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1293053004/1
5 years, 4 months ago (2015-08-18 17:54:09 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-18 17:55:25 UTC) #5
commit-bot: I haz the power
5 years, 4 months ago (2015-08-18 17:55:40 UTC) #6
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/d2168c2de6ed7bab577b889ab413b03a2ca4a274
Cr-Commit-Position: refs/heads/master@{#30232}

Powered by Google App Engine
This is Rietveld 408576698