src/runtime/runtime-symbol.cc - Issue 1293053004: Remove grab-bag includes of v8.h from runtime entries.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: src/runtime/runtime-symbol.cc

Issue 1293053004: Remove grab-bag includes of v8.h from runtime entries. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « src/runtime/runtime-strings.cc ('k') | src/runtime/runtime-test.cc » ('j') | no next file with comments »

OLD	NEW
1 // Copyright 2014 the V8 project authors. All rights reserved.	1 // Copyright 2014 the V8 project authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "src/v8.h"	5 #include "src/runtime/runtime-utils.h"

6	6

7 #include "src/arguments.h"	7 #include "src/arguments.h"

8 #include "src/runtime/runtime-utils.h"	8 #include "src/objects-inl.h"

9	9

10 namespace v8 {	10 namespace v8 {

11 namespace internal {	11 namespace internal {

12	12

13 RUNTIME_FUNCTION(Runtime_CreateSymbol) {	13 RUNTIME_FUNCTION(Runtime_CreateSymbol) {

14 HandleScope scope(isolate);	14 HandleScope scope(isolate);

15 DCHECK(args.length() == 1);	15 DCHECK(args.length() == 1);

16 CONVERT_ARG_HANDLE_CHECKED(Object, name, 0);	16 CONVERT_ARG_HANDLE_CHECKED(Object, name, 0);

17 RUNTIME_ASSERT(name->IsString() \|\| name->IsUndefined());	17 RUNTIME_ASSERT(name->IsString() \|\| name->IsUndefined());

18 Handle<Symbol> symbol = isolate->factory()->NewSymbol();	18 Handle<Symbol> symbol = isolate->factory()->NewSymbol();

(...skipping 48 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
67	67

68	68

69 RUNTIME_FUNCTION(Runtime_SymbolIsPrivate) {	69 RUNTIME_FUNCTION(Runtime_SymbolIsPrivate) {

70 SealHandleScope shs(isolate);	70 SealHandleScope shs(isolate);

71 DCHECK(args.length() == 1);	71 DCHECK(args.length() == 1);

72 CONVERT_ARG_CHECKED(Symbol, symbol, 0);	72 CONVERT_ARG_CHECKED(Symbol, symbol, 0);

73 return isolate->heap()->ToBoolean(symbol->is_private());	73 return isolate->heap()->ToBoolean(symbol->is_private());

74 }	74 }

75 } // namespace internal	75 } // namespace internal

76 } // namespace v8	76 } // namespace v8

OLD	NEW