Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(424)

Unified Diff: ui/aura/env.h

Issue 1293013002: aura: Require explicit ownership of the Env instance. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: . Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/aura/demo/demo_main.cc ('k') | ui/aura/env.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/aura/env.h
diff --git a/ui/aura/env.h b/ui/aura/env.h
index 6fbcb178179a02ee8fbaef2a62ce7238d97e2984..03c48d2ec70efa8f0c8fa724625514d01025b26e 100644
--- a/ui/aura/env.h
+++ b/ui/aura/env.h
@@ -31,14 +31,11 @@ class WindowTreeHost;
// A singleton object that tracks general state within Aura.
class AURA_EXPORT Env : public ui::EventTarget, public base::SupportsUserData {
public:
- // Creates the single Env instance (if it hasn't been created yet). If
- // |create_event_source| is true a PlatformEventSource is created.
- // TODO(sky): nuke |create_event_source|. Only necessary while mojo's
- // nativeviewportservice lives in the same process as the viewmanager.
- static void CreateInstance(bool create_event_source);
+ ~Env() override;
+
+ static scoped_ptr<Env> CreateInstance();
static Env* GetInstance();
static Env* GetInstanceDontCreate();
- static void DeleteInstance();
void AddObserver(EnvObserver* observer);
void RemoveObserver(EnvObserver* observer);
@@ -73,10 +70,8 @@ class AURA_EXPORT Env : public ui::EventTarget, public base::SupportsUserData {
friend class WindowTreeHost;
Env();
- ~Env() override;
- // See description of CreateInstance() for deatils of |create_event_source|.
- void Init(bool create_event_source);
+ void Init();
// Called by the Window when it is initialized. Notifies observers.
void NotifyWindowInitialized(Window* window);
« no previous file with comments | « ui/aura/demo/demo_main.cc ('k') | ui/aura/env.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698