aura: Require explicit ownership of the Env instance.

ui/aura/env.cc

Index: ui/aura/env.cc
diff --git a/ui/aura/env.cc b/ui/aura/env.cc
index 4d2db40d6f1cd33136a5ce42d450a142cc8767e2..0130bcbbe0f3f77e6f9f41d31d47fae3f0f1cd36 100644
--- a/ui/aura/env.cc
+++ b/ui/aura/env.cc
@@ -28,10 +28,18 @@ base::LazyInstance<base::ThreadLocalPointer<Env> >::Leaky lazy_tls_ptr =
 ////////////////////////////////////////////////////////////////////////////////
 // Env, public:
 
+Env::~Env() {
+  FOR_EACH_OBSERVER(EnvObserver, observers_, OnWillDestroyEnv());
+  DCHECK_EQ(this, lazy_tls_ptr.Pointer()->Get());
+  lazy_tls_ptr.Pointer()->Set(NULL);
+}
+
 // static
-void Env::CreateInstance(bool create_event_source) {
-  if (!lazy_tls_ptr.Pointer()->Get())
-    (new Env())->Init(create_event_source);
+scoped_ptr<Env> Env::CreateInstance() {
+  DCHECK(!lazy_tls_ptr.Pointer()->Get());
+  scoped_ptr<Env> env(new Env());
+  env->Init();
+  return env.Pass();
 }
 
 // static
@@ -47,11 +55,6 @@ Env* Env::GetInstanceDontCreate() {
   return lazy_tls_ptr.Pointer()->Get();
 }
 
-// static
-void Env::DeleteInstance() {
-  delete lazy_tls_ptr.Pointer()->Get();
-}
-
 void Env::AddObserver(EnvObserver* observer) {
   observers_.AddObserver(observer);
 }
@@ -77,19 +80,13 @@ Env::Env()
   lazy_tls_ptr.Pointer()->Set(this);
 }
 
-Env::~Env() {
-  FOR_EACH_OBSERVER(EnvObserver, observers_, OnWillDestroyEnv());
-  DCHECK_EQ(this, lazy_tls_ptr.Pointer()->Get());
-  lazy_tls_ptr.Pointer()->Set(NULL);
-}
-
-void Env::Init(bool create_event_source) {
+void Env::Init() {
 #if defined(USE_OZONE)
   // The ozone platform can provide its own event source. So initialize the
   // platform before creating the default event source.
   ui::OzonePlatform::InitializeForUI();
 #endif
-  if (create_event_source && !ui::PlatformEventSource::GetInstance())
+  if (!ui::PlatformEventSource::GetInstance())
     event_source_ = ui::PlatformEventSource::CreateDefault();
 }