Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(611)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1292943002: DevTools: Add total time column to the timeline tree view (Closed)

Created:
5 years, 4 months ago by alph
Modified:
5 years, 4 months ago
Reviewers:
yurys
CC:
blink-reviews, caseq+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

DevTools: Add total time column to the timeline tree view BUG=463547 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200604

Patch Set 1 #

Total comments: 2

Patch Set 2 : addressing comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -56 lines) Patch
M LayoutTests/inspector/tracing/timeline-js-callstacks.html View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/inspector/tracing/timeline-js-callstacks-expected.txt View 1 chunk +49 lines, -49 lines 0 comments Download
M Source/devtools/front_end/timeline/TimelineModel.js View 3 chunks +9 lines, -4 lines 0 comments Download
M Source/devtools/front_end/timeline/TimelineTreeView.js View 4 chunks +9 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
alph
5 years, 4 months ago (2015-08-14 22:37:29 UTC) #2
yurys
lgtm https://codereview.chromium.org/1292943002/diff/1/LayoutTests/inspector/tracing/timeline-js-callstacks.html File LayoutTests/inspector/tracing/timeline-js-callstacks.html (right): https://codereview.chromium.org/1292943002/diff/1/LayoutTests/inspector/tracing/timeline-js-callstacks.html#newcode403 LayoutTests/inspector/tracing/timeline-js-callstacks.html:403: InspectorTest.addResult(" ".repeat(padding) + node.name + ": " + ...
5 years, 4 months ago (2015-08-14 22:59:28 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1292943002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1292943002/1
5 years, 4 months ago (2015-08-15 05:36:01 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1292943002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1292943002/20001
5 years, 4 months ago (2015-08-15 07:58:58 UTC) #10
alph
https://codereview.chromium.org/1292943002/diff/1/LayoutTests/inspector/tracing/timeline-js-callstacks.html File LayoutTests/inspector/tracing/timeline-js-callstacks.html (right): https://codereview.chromium.org/1292943002/diff/1/LayoutTests/inspector/tracing/timeline-js-callstacks.html#newcode403 LayoutTests/inspector/tracing/timeline-js-callstacks.html:403: InspectorTest.addResult(" ".repeat(padding) + node.name + ": " + [node.selfTime, ...
5 years, 4 months ago (2015-08-15 08:09:12 UTC) #11
commit-bot: I haz the power
5 years, 4 months ago (2015-08-15 09:14:27 UTC) #12
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=200604

Powered by Google App Engine
This is Rietveld 408576698