Source/devtools/front_end/timeline/TimelineModel.js - Issue 1292943002: DevTools: Add total time column to the timeline tree view

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/devtools/front_end/timeline/TimelineModel.js

Issue 1292943002: DevTools: Add total time column to the timeline tree view (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: addressing comment Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/inspector/tracing/timeline-js-callstacks-expected.txt ('k') | Source/devtools/front_end/timeline/TimelineTreeView.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/devtools/front_end/timeline/TimelineModel.js

diff --git a/Source/devtools/front_end/timeline/TimelineModel.js b/Source/devtools/front_end/timeline/TimelineModel.js

index 16b07e5a5e1c73aaff4a812d5e7fab2eaa4d4043..51722814e375deeec817ce15a3a07a02d1a79e47 100644

--- a/Source/devtools/front_end/timeline/TimelineModel.js

+++ b/Source/devtools/front_end/timeline/TimelineModel.js

@@ -1561,6 +1561,7 @@ WebInspector.TimelineModel.buildTopDownTree = function(events, startTime, endTim

WebInspector.TimelineModel.buildBottomUpTree = function(topDownTree, groupingCallback)

{

var buRoot = new WebInspector.TimelineModel.ProfileTreeNode();

+ buRoot.selfTime = 0;

buRoot.totalTime = 0;

buRoot.name = WebInspector.UIString("Bottom-Up Chart");

/** @type {!Map<string,!WebInspector.TimelineModel.ProfileTreeNode>} */

@@ -1586,8 +1587,10 @@ WebInspector.TimelineModel.buildBottomUpTree = function(topDownTree, groupingCal

function appendNode(tdNode, buParent)

{

- var time = tdNode.selfTime;

- buParent.totalTime += time;

+ var selfTime = tdNode.selfTime;

+ var totalTime = tdNode.totalTime;

+ buParent.selfTime += selfTime;

+ buParent.totalTime += selfTime;

while (tdNode.parent) {

if (!buParent.children)

buParent.children = /** @type {!Map<string,!WebInspector.TimelineModel.ProfileTreeNode>} */ (new Map());

@@ -1595,13 +1598,15 @@ WebInspector.TimelineModel.buildBottomUpTree = function(topDownTree, groupingCal

var buNode = buParent.children.get(id);

if (!buNode) {

buNode = new WebInspector.TimelineModel.ProfileTreeNode();

- buNode.totalTime = time;

+ buNode.selfTime = selfTime;

+ buNode.totalTime = totalTime;

buNode.name = tdNode.name;

buNode.event = tdNode.event;

buNode.id = id;

buParent.children.set(id, buNode);

} else {

- buNode.totalTime += time;

+ buNode.selfTime += selfTime;

+ buNode.totalTime += totalTime;

}

tdNode = tdNode.parent;

buParent = buNode;