bookmarks: Get rid of TestingProfile::BlockUntilBookmarkModelLoaded().

bookmarks: Get rid of TestingProfile::BlockUntilBookmarkModelLoaded().

BlockUntilBookmarkModelLoaded() is just a tiny wrapper around
WaitForBookmarkModelToLoad(), so it doesn't add much per se,  and we ended up
calling BookmarkModelFactory::GetForProfile() twice, either before or after
the call to BlockUntilBookmarkModelLoaded().

BUG=144783
R=sky@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=190511

[tfarina, 2013-03-22 00:15:50]

Scott,

You will see that most of places followed one of these two patterns:

Either:

ui_test_utils::WaitForBookmarkModelToLoad(
    BookmarkModelFactory::GetForProfile(...));

Or:
ui_test_utils::WaitForBookmarkModelToLoad(model);


I think even though we had to call BookmarkModelFactory::GetForProfile at some
places, in many we hadn't and it may be a win because now we have a single way
to block/wait for bookmark model to load.

Let me know what you think.

Thank you,

[sky, 2013-03-22 23:46:06]

https://codereview.chromium.org/12929016/diff/6001/chrome/browser/browser_com...
File chrome/browser/browser_commands_unittest.cc (right):

https://codereview.chromium.org/12929016/diff/6001/chrome/browser/browser_com...
chrome/browser/browser_commands_unittest.cc:144: BookmarkModel* model =
BookmarkModelFactory::GetForProfile(profile());
As so many places just have a profile and you can you provide a variant that
takes a profile too?

[tfarina, 2013-03-23 00:55:23]

Please, take another look.

https://codereview.chromium.org/12929016/diff/6001/chrome/browser/browser_com...
File chrome/browser/browser_commands_unittest.cc (right):

https://codereview.chromium.org/12929016/diff/6001/chrome/browser/browser_com...
chrome/browser/browser_commands_unittest.cc:144: BookmarkModel* model =
BookmarkModelFactory::GetForProfile(profile());
On 2013/03/22 23:46:06, sky wrote:
> As so many places just have a profile and you can you provide a variant that
> takes a profile too?

Done.

[sky, 2013-03-25 15:47:28]

LGTM

[commit-bot: I haz the power, 2013-03-25 21:41:51]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tfarina@chromium.org/12929016/15001

[tfarina, 2013-03-25 23:06:46]

Committed patchset #4 manually as r190511 (presubmit successful).