Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(401)

Unified Diff: chrome/browser/bookmarks/bookmark_node_data_unittest.cc

Issue 12929016: bookmarks: Get rid of TestingProfile::BlockUntilBookmarkModelLoaded(). (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix win Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/bookmarks/bookmark_node_data_unittest.cc
diff --git a/chrome/browser/bookmarks/bookmark_node_data_unittest.cc b/chrome/browser/bookmarks/bookmark_node_data_unittest.cc
index 86e2e017e3322c78fa41bc845fe7144825062c95..075049736a25906f9b41ba4c77b695c32b84b8d5 100644
--- a/chrome/browser/bookmarks/bookmark_node_data_unittest.cc
+++ b/chrome/browser/bookmarks/bookmark_node_data_unittest.cc
@@ -10,6 +10,7 @@
#include "chrome/browser/bookmarks/bookmark_model_factory.h"
#include "chrome/browser/bookmarks/bookmark_node_data.h"
#include "chrome/test/base/testing_profile.h"
+#include "chrome/test/base/ui_test_utils.h"
#include "content/public/test/test_browser_thread.h"
#include "googleurl/src/gurl.h"
#include "testing/gtest/include/gtest/gtest.h"
@@ -76,10 +77,10 @@ TEST_F(BookmarkNodeDataTest, JustURL) {
TEST_F(BookmarkNodeDataTest, URL) {
// Write a single node representing a URL to the clipboard.
TestingProfile profile;
- profile.CreateBookmarkModel(false);
- profile.BlockUntilBookmarkModelLoaded();
profile.SetID(L"id");
+ profile.CreateBookmarkModel(false);
BookmarkModel* model = BookmarkModelFactory::GetForProfile(&profile);
+ ui_test_utils::WaitForBookmarkModelToLoad(model);
const BookmarkNode* root = model->bookmark_bar_node();
GURL url(GURL("http://foo.com"));
const string16 title(ASCIIToUTF16("foo.com"));
@@ -119,10 +120,12 @@ TEST_F(BookmarkNodeDataTest, URL) {
// Tests writing a folder to the clipboard.
TEST_F(BookmarkNodeDataTest, Folder) {
TestingProfile profile;
- profile.CreateBookmarkModel(false);
- profile.BlockUntilBookmarkModelLoaded();
profile.SetID(L"id");
+ profile.CreateBookmarkModel(false);
+
BookmarkModel* model = BookmarkModelFactory::GetForProfile(&profile);
+ ui_test_utils::WaitForBookmarkModelToLoad(model);
+
const BookmarkNode* root = model->bookmark_bar_node();
const BookmarkNode* g1 = model->AddFolder(root, 0, ASCIIToUTF16("g1"));
const BookmarkNode* g11 = model->AddFolder(g1, 0, ASCIIToUTF16("g11"));
@@ -160,8 +163,10 @@ TEST_F(BookmarkNodeDataTest, FolderWithChild) {
TestingProfile profile;
profile.SetID(L"id");
profile.CreateBookmarkModel(false);
- profile.BlockUntilBookmarkModelLoaded();
+
BookmarkModel* model = BookmarkModelFactory::GetForProfile(&profile);
+ ui_test_utils::WaitForBookmarkModelToLoad(model);
+
const BookmarkNode* root = model->bookmark_bar_node();
const BookmarkNode* folder = model->AddFolder(root, 0, ASCIIToUTF16("g1"));
@@ -199,8 +204,10 @@ TEST_F(BookmarkNodeDataTest, MultipleNodes) {
TestingProfile profile;
profile.SetID(L"id");
profile.CreateBookmarkModel(false);
- profile.BlockUntilBookmarkModelLoaded();
+
BookmarkModel* model = BookmarkModelFactory::GetForProfile(&profile);
+ ui_test_utils::WaitForBookmarkModelToLoad(model);
+
const BookmarkNode* root = model->bookmark_bar_node();
const BookmarkNode* folder = model->AddFolder(root, 0, ASCIIToUTF16("g1"));

Powered by Google App Engine
This is Rietveld 408576698