Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7342)

Unified Diff: chrome/browser/ui/webui/signin/login_ui_service.cc

Issue 12929014: Identity API: Pop-up a sign-in dialog if gaia credentials are bad (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@lkgr
Patch Set: fix signin browser test for chromeos Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/signin/signin_browsertest.cc ('k') | chrome/chrome_browser_extensions.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/webui/signin/login_ui_service.cc
diff --git a/chrome/browser/ui/webui/signin/login_ui_service.cc b/chrome/browser/ui/webui/signin/login_ui_service.cc
index 69b2bb0694fb9a02698f55e3c27b64428e0cbd59..31ad5fc2554853e456a2dff65d05eda795efc7d9 100644
--- a/chrome/browser/ui/webui/signin/login_ui_service.cc
+++ b/chrome/browser/ui/webui/signin/login_ui_service.cc
@@ -6,6 +6,7 @@
#include "chrome/browser/profiles/profile.h"
#include "chrome/browser/ui/browser.h"
+#include "chrome/browser/ui/browser_finder.h"
#include "chrome/browser/ui/browser_navigator.h"
#include "chrome/browser/ui/chrome_pages.h"
#include "chrome/browser/ui/host_desktop.h"
@@ -42,23 +43,7 @@ void LoginUIService::LoginUIClosed(LoginUI* ui) {
}
void LoginUIService::ShowLoginPopup() {
- if (current_login_ui()) {
- current_login_ui()->FocusUI();
- return;
- }
-
- Browser* browser =
- new Browser(Browser::CreateParams(Browser::TYPE_POPUP, profile_,
- chrome::GetActiveDesktop()));
- // TODO(munjal): Change the source from SOURCE_NTP_LINK to something else
- // once we have added a new source for extension API.
- GURL signin_url(SyncPromoUI::GetSyncPromoURL(GURL(),
- SyncPromoUI::SOURCE_NTP_LINK,
- true));
- chrome::NavigateParams params(browser,
- signin_url,
- content::PAGE_TRANSITION_AUTO_TOPLEVEL);
- params.disposition = CURRENT_TAB;
- params.window_action = chrome::NavigateParams::SHOW_WINDOW;
- chrome::Navigate(&params);
+ Browser* browser = FindOrCreateTabbedBrowser(profile_,
+ chrome::GetActiveDesktop());
+ chrome::ShowBrowserSignin(browser, SyncPromoUI::SOURCE_APP_LAUNCHER);
}
« no previous file with comments | « chrome/browser/signin/signin_browsertest.cc ('k') | chrome/chrome_browser_extensions.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698