Identity API: Pop-up a sign-in dialog if gaia credentials are bad

chrome/browser/signin/signin_browsertest.cc

Index: chrome/browser/signin/signin_browsertest.cc
diff --git a/chrome/browser/signin/signin_browsertest.cc b/chrome/browser/signin/signin_browsertest.cc
index e3666ce7897b31e79dabe35c159221a4ad5cb86b..3b2644a11d435eb60ea1714a03189ed0356138f4 100644
--- a/chrome/browser/signin/signin_browsertest.cc
+++ b/chrome/browser/signin/signin_browsertest.cc
@@ -8,6 +8,7 @@
 #include "chrome/browser/signin/signin_manager.h"
 #include "chrome/browser/signin/signin_manager_factory.h"
 #include "chrome/browser/ui/browser.h"
+#include "chrome/browser/ui/singleton_tabs.h"
 #include "chrome/browser/ui/tabs/tab_strip_model.h"
 #include "chrome/browser/ui/webui/signin/login_ui_service.h"
 #include "chrome/browser/ui/webui/signin/login_ui_service_factory.h"
@@ -91,9 +92,13 @@ IN_PROC_BROWSER_TEST_F(SigninBrowserTest, ProcessIsolation) {
 
   // Entry points to signin request "SINGLETON_TAB" mode, so a new request
   // shouldn't change anything.
-  LoginUIService* login = LoginUIServiceFactory::GetForProfile(
-      browser()->profile());
-  login->ShowLoginPopup();
+  chrome::NavigateParams params(chrome::GetSingletonTabNavigateParams(
+      browser(),
+      GURL(SyncPromoUI::GetSyncPromoURL(GURL(),
+                                        SyncPromoUI::SOURCE_NTP_LINK,
+                                        false))));
+  params.path_behavior = chrome::NavigateParams::IGNORE_AND_NAVIGATE;
+  ShowSingletonTabOverwritingNTP(browser(), params);
   EXPECT_EQ(active_tab, browser()->tab_strip_model()->GetActiveWebContents());
   EXPECT_EQ(kOneClickSigninEnabled,
             signin->IsSigninProcess(active_tab_process_id));