Source/core/html/HTMLSelectElement.cpp - Issue 1292653003: [bindings] Avoid using custom binding for HTMLOptionsCollection.length attribute

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/HTMLSelectElement.cpp

Issue 1292653003: [bindings] Avoid using custom binding for HTMLOptionsCollection.length attribute (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Missed to fix the test case! Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/html/HTMLSelectElement.cpp

diff --git a/Source/core/html/HTMLSelectElement.cpp b/Source/core/html/HTMLSelectElement.cpp

index 1e3f930f92c435c6f88ee970b56b4320ec430bda..97211dd196d0307a5f370aab21343b5de460ed1d 100644

--- a/Source/core/html/HTMLSelectElement.cpp

+++ b/Source/core/html/HTMLSelectElement.cpp

@@ -486,7 +486,7 @@ void HTMLSelectElement::setOption(unsigned index, HTMLOptionElement* option, Exc

void HTMLSelectElement::setLength(unsigned newLen, ExceptionState& exceptionState)

{

if (newLen > maxSelectItems)

- newLen = maxSelectItems;

+ return;

int diff = length() - newLen;

if (diff < 0) { // Add dummy elements.

« no previous file with comments | « Source/core/html/HTMLOptionsCollection.idl ('k') | no next file » | no next file with comments »