Source/core/html/HTMLOptionsCollection.idl - Issue 1292653003: [bindings] Avoid using custom binding for HTMLOptionsCollection.length attribute

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/HTMLOptionsCollection.idl

Issue 1292653003: [bindings] Avoid using custom binding for HTMLOptionsCollection.length attribute (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Missed to fix the test case! Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/html/HTMLOptionsCollection.idl

diff --git a/Source/core/html/HTMLOptionsCollection.idl b/Source/core/html/HTMLOptionsCollection.idl

index 7a9fabfd63e862a952043cbff9b4d090f8c8741f..bbbc970e77fe4e02edcb4584cf06a92c59875d4a 100644

--- a/Source/core/html/HTMLOptionsCollection.idl

+++ b/Source/core/html/HTMLOptionsCollection.idl

@@ -26,7 +26,7 @@

SetWrapperReferenceFrom=ownerNode,

] interface HTMLOptionsCollection : HTMLCollection {

// inherits item()

- [Custom=Setter, RaisesException=Setter] attribute unsigned long length; // shadows inherited length

+ [RaisesException=Setter] attribute unsigned long length; // shadows inherited length

// FIXME: The spec has a legacycaller HTMLOptionElement? (DOMString name);

[RaisesException, TypeChecking=Interface] setter void (unsigned long index, HTMLOptionElement? option);

[RaisesException, TypeChecking=Interface] void add((HTMLOptionElement or HTMLOptGroupElement) element, optional (HTMLElement or long)? before = null);

« no previous file with comments | « Source/bindings/core/v8/custom/custom.gypi ('k') | Source/core/html/HTMLSelectElement.cpp » ('j') | no next file with comments »