Source/bindings/core/v8/custom/custom.gypi - Issue 1292653003: [bindings] Avoid using custom binding for HTMLOptionsCollection.length attribute

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/core/v8/custom/custom.gypi

Issue 1292653003: [bindings] Avoid using custom binding for HTMLOptionsCollection.length attribute (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Missed to fix the test case! Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/bindings/core/v8/custom/V8HTMLOptionsCollectionCustom.cpp ('k') | Source/core/html/HTMLOptionsCollection.idl » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/bindings/core/v8/custom/custom.gypi

diff --git a/Source/bindings/core/v8/custom/custom.gypi b/Source/bindings/core/v8/custom/custom.gypi

index c40c8945c9e5902d196d396d74570b0ce23de61c..ae9073e1455cf0d97bb64d4fc3c74f76aaa3bea0 100644

--- a/Source/bindings/core/v8/custom/custom.gypi

+++ b/Source/bindings/core/v8/custom/custom.gypi

@@ -14,7 +14,6 @@

'V8ErrorEventCustom.cpp',

'V8EventTargetCustom.cpp',

'V8HTMLAllCollectionCustom.cpp',

- 'V8HTMLOptionsCollectionCustom.cpp',

'V8HTMLPlugInElementCustom.cpp',

'V8InjectedScriptManager.cpp',

'V8MediaQueryListCustom.cpp',

« no previous file with comments | « Source/bindings/core/v8/custom/V8HTMLOptionsCollectionCustom.cpp ('k') | Source/core/html/HTMLOptionsCollection.idl » ('j') | no next file with comments »