LayoutTests/fast/dom/HTMLSelectElement/select-selectedIndex-multiple.html - Issue 1292653003: [bindings] Avoid using custom binding for HTMLOptionsCollection.length attribute

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/fast/dom/HTMLSelectElement/select-selectedIndex-multiple.html

Issue 1292653003: [bindings] Avoid using custom binding for HTMLOptionsCollection.length attribute (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Missed to fix the test case! Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/fast/dom/HTMLSelectElement/select-selectedIndex-expected.txt ('k') | LayoutTests/fast/dom/HTMLSelectElement/select-selectedIndex-multiple-expected.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: LayoutTests/fast/dom/HTMLSelectElement/select-selectedIndex-multiple.html

diff --git a/LayoutTests/fast/dom/HTMLSelectElement/select-selectedIndex-multiple.html b/LayoutTests/fast/dom/HTMLSelectElement/select-selectedIndex-multiple.html

index dba6a7dd6a1e317c0635887024287c2e4ac62a5d..d1430b9dcba91e46954391cb0bf7d829d77d282e 100644

--- a/LayoutTests/fast/dom/HTMLSelectElement/select-selectedIndex-multiple.html

+++ b/LayoutTests/fast/dom/HTMLSelectElement/select-selectedIndex-multiple.html

@@ -14,7 +14,7 @@ reset(mySelect);

var i = 0;

debug((++i) + ") setting length to a negative length");

-shouldThrow("mySelect.options.length = -1;");

+mySelect.options.length = -1;

shouldBe("mySelect.options.length", "2");

shouldBe("mySelect.selectedIndex", "0");

@@ -137,5 +137,10 @@ mySelect.options[1/0] = document.createElement("option");

shouldBe("mySelect.options.length", "10");

shouldBe("mySelect.selectedIndex", "0");

+debug((++i) + ") setting length to a value greater than 10000");

+mySelect.options.length = 10001;

+shouldBe("mySelect.options.length", "10");

+shouldBe("mySelect.selectedIndex", "0");

debug("");

</script>