LayoutTests/fast/dom/HTMLSelectElement/select-selectedIndex-expected.txt - Issue 1292653003: [bindings] Avoid using custom binding for HTMLOptionsCollection.length attribute

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/fast/dom/HTMLSelectElement/select-selectedIndex-expected.txt

Issue 1292653003: [bindings] Avoid using custom binding for HTMLOptionsCollection.length attribute (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Missed to fix the test case! Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/fast/dom/HTMLSelectElement/select-selectedIndex.html ('k') | LayoutTests/fast/dom/HTMLSelectElement/select-selectedIndex-multiple.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: LayoutTests/fast/dom/HTMLSelectElement/select-selectedIndex-expected.txt

diff --git a/LayoutTests/fast/dom/HTMLSelectElement/select-selectedIndex-expected.txt b/LayoutTests/fast/dom/HTMLSelectElement/select-selectedIndex-expected.txt

index 10622b03969e85c95a283657988b441a89f8aee7..86b5abe51ff00dbdf5d6ed71eb8882effa3bbb76 100644

--- a/LayoutTests/fast/dom/HTMLSelectElement/select-selectedIndex-expected.txt

+++ b/LayoutTests/fast/dom/HTMLSelectElement/select-selectedIndex-expected.txt

@@ -1,6 +1,5 @@

1) setting length to a negative length

-PASS mySelect.options.length = -1; threw exception IndexSizeError: Failed to set the 'length' property on 'HTMLOptionsCollection': The value provided (-1) is negative. Lengths must be greater than or equal to 0..

PASS mySelect.options.length is 2

PASS mySelect.selectedIndex is 1

2) setting length to a larger length

@@ -73,6 +72,9 @@ PASS mySelect.selectedIndex is -1

PASS mySelect.options.add({}) threw exception TypeError: Failed to execute 'add' on 'HTMLOptionsCollection': The provided value is not of type '(HTMLOptionElement or HTMLOptGroupElement)'.

PASS mySelect.options.length is 10

PASS mySelect.selectedIndex is -1

+24) setting length to a value greater than 10000

+PASS mySelect.options.length is 10

+PASS mySelect.selectedIndex is -1

PASS successfullyParsed is true