Issue 1292653002: Merge to XFA: Remove if checks after new.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1292653002: Merge to XFA: Remove if checks after new. (Closed)

Created:
5 years, 4 months ago by Lei Zhang

Modified:
5 years, 4 months ago

Reviewers:
Tom Sepez

CC:
pdfium-reviews_googlegroups.com

Base URL:
https://pdfium.googlesource.com/pdfium@xfa

Target Ref:
refs/heads/xfa

Visibility:
Public.

Merge to XFA: Remove if checks after new. R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1287863002 . (cherry picked from commit 388a3b0b8d6f75d47978c08299300f121f04884c) Committed: https://pdfium.googlesource.com/pdfium/+/e00660b5fa41956db06c557807b68a1117d1b70b

Created: 5 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+35 lines, -53 lines)			Patch
M	core/src/fxge/apple/fx_quartz_device.cpp	View	2 chunks	+0 lines, -6 lines	0 comments	Download
M	fpdfsdk/include/fxedit/fxet_edit.h	View	2 chunks	+9 lines, -10 lines	0 comments	Download
M	fpdfsdk/include/javascript/JS_Object.h	View	1 chunk	+4 lines, -5 lines	0 comments	Download
M	fpdfsdk/src/fxedit/fxet_list.cpp	View	1 chunk	+5 lines, -6 lines	0 comments	Download
M	fpdfsdk/src/javascript/app.cpp	View	1 chunk	+3 lines, -10 lines	0 comments	Download
M	fpdfsdk/src/pdfwindow/PWL_Wnd.cpp	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	samples/pdfium_test.cc	View	1 chunk	+12 lines, -14 lines	0 comments	Download

Total messages: 2 (0 generated)

Lei Zhang

TBR, clean merge. Will land when the commit passes on the waterfall.

5 years, 4 months ago (2015-08-13 22:27:51 UTC) #1

Lei Zhang

5 years, 4 months ago (2015-08-13 22:40:21 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
e00660b5fa41956db06c557807b68a1117d1b70b (presubmit successful).