Remove if checks after new.

Remove if checks after new.

R=tsepez@chromium.org

Committed: https://pdfium.googlesource.com/pdfium/+/388a3b0b8d6f75d47978c08299300f121f04884c

[Lei Zhang, 2015-08-12 02:01:43]

thestig@chromium.org changed reviewers:
+ tsepez@chromium.org

[Tom Sepez, 2015-08-12 22:20:37]

LGTM.

https://codereview.chromium.org/1287863002/diff/1/fpdfsdk/include/fxedit/fxet...
File fpdfsdk/include/fxedit/fxet_edit.h (right):

https://codereview.chromium.org/1287863002/diff/1/fpdfsdk/include/fxedit/fxet...
fpdfsdk/include/fxedit/fxet_edit.h:118: CFX_Edit_LineRect* pRect = new
CFX_Edit_LineRect(wrLine, rcLine);
nit: just m_LineRects.Add(new CFX_Edit_LineRect(wrline, rcline));

https://codereview.chromium.org/1287863002/diff/1/fpdfsdk/include/fxedit/fxet...
fpdfsdk/include/fxedit/fxet_edit.h:156: m_Rects.Add(pNewRect);
nit: just m_Rects.Add(new CPDF_Rect(rect));

https://codereview.chromium.org/1287863002/diff/1/fpdfsdk/include/javascript/...
File fpdfsdk/include/javascript/JS_Object.h (right):

https://codereview.chromium.org/1287863002/diff/1/fpdfsdk/include/javascript/...
fpdfsdk/include/javascript/JS_Object.h:113: pMap->nID = nIndex;
nit: Pity the ctor doesn't take these and set them.

[Tom Sepez, 2015-08-13 15:39:54]

https://codereview.chromium.org/1287863002/diff/1/fpdfsdk/include/javascript/...
File fpdfsdk/include/javascript/JS_Object.h (right):

https://codereview.chromium.org/1287863002/diff/1/fpdfsdk/include/javascript/...
fpdfsdk/include/javascript/JS_Object.h:115: m_Array.Add(pMap);
as a follow-up, note that all this JS_TIMER_MAP / CTimerMapArray /
JS_TIMER_MAPARRAY should be deleted and replaced with
  std::map<FX_UINT, CJS_Timer*>

[Tom Sepez, 2015-08-13 20:48:13]

https://codereview.chromium.org/1287863002/diff/1/fpdfsdk/include/javascript/...
File fpdfsdk/include/javascript/JS_Object.h (right):

https://codereview.chromium.org/1287863002/diff/1/fpdfsdk/include/javascript/...
fpdfsdk/include/javascript/JS_Object.h:115: m_Array.Add(pMap);
On 2015/08/13 15:39:54, Tom Sepez (slow until Aug 14) wrote:
> as a follow-up, note that all this JS_TIMER_MAP / CTimerMapArray /
> JS_TIMER_MAPARRAY should be deleted and replaced with
>   std::map<FX_UINT, CJS_Timer*>
NM. See 
https://codereview.chromium.org/1286383004/

[Lei Zhang, 2015-08-13 22:23:57]

https://codereview.chromium.org/1287863002/diff/1/fpdfsdk/include/fxedit/fxet...
File fpdfsdk/include/fxedit/fxet_edit.h (right):

https://codereview.chromium.org/1287863002/diff/1/fpdfsdk/include/fxedit/fxet...
fpdfsdk/include/fxedit/fxet_edit.h:118: CFX_Edit_LineRect* pRect = new
CFX_Edit_LineRect(wrLine, rcLine);
On 2015/08/12 22:20:37, Tom Sepez (slow until Aug 14) wrote:
> nit: just m_LineRects.Add(new CFX_Edit_LineRect(wrline, rcline));

Done.

https://codereview.chromium.org/1287863002/diff/1/fpdfsdk/include/fxedit/fxet...
fpdfsdk/include/fxedit/fxet_edit.h:156: m_Rects.Add(pNewRect);
On 2015/08/12 22:20:37, Tom Sepez (slow until Aug 14) wrote:
> nit: just m_Rects.Add(new CPDF_Rect(rect));

Done.

https://codereview.chromium.org/1287863002/diff/1/fpdfsdk/include/javascript/...
File fpdfsdk/include/javascript/JS_Object.h (right):

https://codereview.chromium.org/1287863002/diff/1/fpdfsdk/include/javascript/...
fpdfsdk/include/javascript/JS_Object.h:115: m_Array.Add(pMap);
On 2015/08/13 20:48:13, Tom Sepez (slow until Aug 14) wrote:
> On 2015/08/13 15:39:54, Tom Sepez (slow until Aug 14) wrote:
> > as a follow-up, note that all this JS_TIMER_MAP / CTimerMapArray /
> > JS_TIMER_MAPARRAY should be deleted and replaced with
> >   std::map<FX_UINT, CJS_Timer*>
> NM. See 
> https://codereview.chromium.org/1286383004/

Leaving this file as is.

[Lei Zhang, 2015-08-13 22:24:23]

Committed patchset #3 (id:40001) manually as
388a3b0b8d6f75d47978c08299300f121f04884c (presubmit successful).