Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(158)

Issue 1292533003: Debugger: simplify calling into Javascript. (Closed)

Created:
5 years, 4 months ago by Yang
Modified:
5 years, 4 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Debugger: simplify calling into Javascript. R=jkummerow@chromium.org Committed: https://crrev.com/c47d9d07e7facd49e828be1c38f0e53bd61f0d1c Cr-Commit-Position: refs/heads/master@{#30170}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -74 lines) Patch
M src/debug/debug.h View 3 chunks +2 lines, -8 lines 0 comments Download
M src/debug/debug.cc View 8 chunks +25 lines, -66 lines 1 comment Download

Messages

Total messages: 7 (1 generated)
Yang
5 years, 4 months ago (2015-08-13 13:51:20 UTC) #1
Jakob Kummerow
LGTM https://codereview.chromium.org/1292533003/diff/1/src/debug/debug.cc File src/debug/debug.cc (right): https://codereview.chromium.org/1292533003/diff/1/src/debug/debug.cc#newcode1959 src/debug/debug.cc:1959: Handle<Object> argv[] = {Script::GetWrapper(script)}; nit: we like spaces ...
5 years, 4 months ago (2015-08-13 14:57:36 UTC) #2
Yang
On 2015/08/13 14:57:36, Jakob wrote: > LGTM > > https://codereview.chromium.org/1292533003/diff/1/src/debug/debug.cc > File src/debug/debug.cc (right): > ...
5 years, 4 months ago (2015-08-14 07:11:10 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1292533003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1292533003/1
5 years, 4 months ago (2015-08-14 07:11:20 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-14 07:36:43 UTC) #6
commit-bot: I haz the power
5 years, 4 months ago (2015-08-14 07:37:02 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c47d9d07e7facd49e828be1c38f0e53bd61f0d1c
Cr-Commit-Position: refs/heads/master@{#30170}

Powered by Google App Engine
This is Rietveld 408576698