Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(376)

Unified Diff: src/debug/debug.h

Issue 1292533003: Debugger: simplify calling into Javascript. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/debug/debug.cc » ('j') | src/debug/debug.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/debug/debug.h
diff --git a/src/debug/debug.h b/src/debug/debug.h
index 4290b95913004b4aca28baef51a2388168fed3b6..4b5b7b7b90e176339b8ca6f5aba740420c43e965 100644
--- a/src/debug/debug.h
+++ b/src/debug/debug.h
@@ -494,10 +494,6 @@ class Debug {
base::NoBarrier_Load(&thread_local_.current_debug_scope_));
}
inline Handle<Context> debug_context() { return debug_context_; }
- inline Handle<Object> debug_utils() {
- AssertDebugContext();
- return isolate_->natives_utils_object();
- }
void set_live_edit_enabled(bool v) { live_edit_enabled_ = v; }
bool live_edit_enabled() const {
@@ -553,10 +549,6 @@ class Debug {
void OnException(Handle<Object> exception, Handle<Object> promise);
// Constructors for debug event objects.
- MUST_USE_RESULT MaybeHandle<Object> MakeJSObject(
- const char* constructor_name,
- int argc,
- Handle<Object> argv[]);
MUST_USE_RESULT MaybeHandle<Object> MakeExecutionState();
MUST_USE_RESULT MaybeHandle<Object> MakeBreakEvent(
Handle<Object> break_points_hit);
@@ -600,6 +592,8 @@ class Debug {
void RemoveDebugInfoAndClearFromShared(Handle<DebugInfo> debug_info);
Handle<Object> CheckBreakPoints(Handle<Object> break_point);
bool CheckBreakPoint(Handle<Object> break_point_object);
+ MaybeHandle<Object> CallFunction(const char* name, int argc,
+ Handle<Object> args[]);
inline void AssertDebugContext() {
DCHECK(isolate_->context() == *debug_context());
« no previous file with comments | « no previous file | src/debug/debug.cc » ('j') | src/debug/debug.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698