cc: Formatted gl_renderer_unittest.cc according to Chromium style.

cc: Formatted gl_renderer_unittest.cc according to Chromium style.


BUG=


Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=190219

[danakj, 2013-03-22 21:44:12]

LGTM with a few things to fix.

https://codereview.chromium.org/12924003/diff/1/cc/output/gl_renderer_unittes...
File cc/output/gl_renderer_unittest.cc (right):

https://codereview.chromium.org/12924003/diff/1/cc/output/gl_renderer_unittes...
cc/output/gl_renderer_unittest.cc:102: int FrameCount() { return frame_; }
frame_count()

https://codereview.chromium.org/12924003/diff/1/cc/output/gl_renderer_unittes...
cc/output/gl_renderer_unittest.cc:110: memory_allocation_changed_callback_;
indent 4 spaces (line continuation)

https://codereview.chromium.org/12924003/diff/1/cc/output/gl_renderer_unittes...
cc/output/gl_renderer_unittest.cc:133: static gfx::Size fakeSize(1, 1);
fake_size

script is not perfect yet :(

https://codereview.chromium.org/12924003/diff/1/cc/output/gl_renderer_unittes...
cc/output/gl_renderer_unittest.cc:161: int SetFullRootLayerDamageCount() const {
set_full_root_layer_damage_count()

https://codereview.chromium.org/12924003/diff/1/cc/output/gl_renderer_unittes...
cc/output/gl_renderer_unittest.cc:164: void
SetLastCallWasSetVisibilityPointer(bool* last_call_was_set_visibility) {
set_last_call_...

https://codereview.chromium.org/12924003/diff/1/cc/output/gl_renderer_unittes...
cc/output/gl_renderer_unittest.cc:169: RenderPassList& RenderPassesInDrawOrder()
{
render_passes_in_draw_order()

this should return RenderPassList* (no non-const refs allowed)

https://codereview.chromium.org/12924003/diff/1/cc/output/gl_renderer_unittes...
cc/output/gl_renderer_unittest.cc:173: size_t MemoryAllocationLimitBytes() const
{
memory_allocation_limit_bytes()

https://codereview.chromium.org/12924003/diff/1/cc/output/gl_renderer_unittes...
cc/output/gl_renderer_unittest.cc:221:
FrameCountingMemoryAllocationSettingContext* Context() {
context()

https://codereview.chromium.org/12924003/diff/1/cc/output/gl_renderer_unittes...
cc/output/gl_renderer_unittest.cc:253:
SuggestBackbufferNoShouldDiscardBackbufferAndDamageRootLayerWhileNotVisible) {
there's no hope of 80 col here. put GLRendererTest on the same line as TEST_F
and just let this go past 80 (as it is already)

https://codereview.chromium.org/12924003/diff/1/cc/output/gl_renderer_unittes...
cc/output/gl_renderer_unittest.cc:320: virtual bool GetActiveAttrib(WebGLId
program, WGC3Duint index, ActiveInfo&) {
need a variable name for all parameters

https://codereview.chromium.org/12924003/diff/1/cc/output/gl_renderer_unittes...
cc/output/gl_renderer_unittest.cc:324: virtual bool GetActiveUniform(WebGLId
program, WGC3Duint index, ActiveInfo&) {
need a variable name for all parameters

https://codereview.chromium.org/12924003/diff/1/cc/output/gl_renderer_unittes...
cc/output/gl_renderer_unittest.cc:554: int ClearCount() const { return clear_; }
clear_count()

https://codereview.chromium.org/12924003/diff/1/cc/output/gl_renderer_unittes...
cc/output/gl_renderer_unittest.cc:646: void
SetLastCallWasSetVisibilityPointer(bool* last_call_was_set_visibility) {
set_last_call_was..

https://codereview.chromium.org/12924003/diff/1/cc/output/gl_renderer_unittes...
cc/output/gl_renderer_unittest.cc:706: WGC3Denum ActiveTexture() const { return
active_texture_; }
active_texture()

https://codereview.chromium.org/12924003/diff/1/cc/output/gl_renderer_unittes...
cc/output/gl_renderer_unittest.cc:984: OutputSurfaceMockContext* Context() {
context()

[ernstm, 2013-03-22 22:15:52]

https://codereview.chromium.org/12924003/diff/1/cc/output/gl_renderer_unittes...
File cc/output/gl_renderer_unittest.cc (right):

https://codereview.chromium.org/12924003/diff/1/cc/output/gl_renderer_unittes...
cc/output/gl_renderer_unittest.cc:102: int FrameCount() { return frame_; }
On 2013/03/22 21:44:12, danakj wrote:
> frame_count()

Done.

https://codereview.chromium.org/12924003/diff/1/cc/output/gl_renderer_unittes...
cc/output/gl_renderer_unittest.cc:110: memory_allocation_changed_callback_;
On 2013/03/22 21:44:12, danakj wrote:
> indent 4 spaces (line continuation)

Done.

https://codereview.chromium.org/12924003/diff/1/cc/output/gl_renderer_unittes...
cc/output/gl_renderer_unittest.cc:133: static gfx::Size fakeSize(1, 1);
On 2013/03/22 21:44:12, danakj wrote:
> fake_size
> 
> script is not perfect yet :(

Done.

https://codereview.chromium.org/12924003/diff/1/cc/output/gl_renderer_unittes...
cc/output/gl_renderer_unittest.cc:161: int SetFullRootLayerDamageCount() const {
On 2013/03/22 21:44:12, danakj wrote:
> set_full_root_layer_damage_count()

Done.

https://codereview.chromium.org/12924003/diff/1/cc/output/gl_renderer_unittes...
cc/output/gl_renderer_unittest.cc:164: void
SetLastCallWasSetVisibilityPointer(bool* last_call_was_set_visibility) {
On 2013/03/22 21:44:12, danakj wrote:
> set_last_call_...

Done.

https://codereview.chromium.org/12924003/diff/1/cc/output/gl_renderer_unittes...
cc/output/gl_renderer_unittest.cc:169: RenderPassList& RenderPassesInDrawOrder()
{
On 2013/03/22 21:44:12, danakj wrote:
> render_passes_in_draw_order()
> 
> this should return RenderPassList* (no non-const refs allowed)

Done.

https://codereview.chromium.org/12924003/diff/1/cc/output/gl_renderer_unittes...
cc/output/gl_renderer_unittest.cc:173: size_t MemoryAllocationLimitBytes() const
{
On 2013/03/22 21:44:12, danakj wrote:
> memory_allocation_limit_bytes()

Done.

https://codereview.chromium.org/12924003/diff/1/cc/output/gl_renderer_unittes...
cc/output/gl_renderer_unittest.cc:221:
FrameCountingMemoryAllocationSettingContext* Context() {
On 2013/03/22 21:44:12, danakj wrote:
> context()

Done.

https://codereview.chromium.org/12924003/diff/1/cc/output/gl_renderer_unittes...
cc/output/gl_renderer_unittest.cc:253:
SuggestBackbufferNoShouldDiscardBackbufferAndDamageRootLayerWhileNotVisible) {
On 2013/03/22 21:44:12, danakj wrote:
> there's no hope of 80 col here. put GLRendererTest on the same line as TEST_F
> and just let this go past 80 (as it is already)

Done.

https://codereview.chromium.org/12924003/diff/1/cc/output/gl_renderer_unittes...
cc/output/gl_renderer_unittest.cc:320: virtual bool GetActiveAttrib(WebGLId
program, WGC3Duint index, ActiveInfo&) {
On 2013/03/22 21:44:12, danakj wrote:
> need a variable name for all parameters
Done. Also changed all get* functions back to lower-case first letter, as these
are virtual function overloads (missed those in the first pass)

https://codereview.chromium.org/12924003/diff/1/cc/output/gl_renderer_unittes...
cc/output/gl_renderer_unittest.cc:324: virtual bool GetActiveUniform(WebGLId
program, WGC3Duint index, ActiveInfo&) {
On 2013/03/22 21:44:12, danakj wrote:
> need a variable name for all parameters

Done.

https://codereview.chromium.org/12924003/diff/1/cc/output/gl_renderer_unittes...
cc/output/gl_renderer_unittest.cc:554: int ClearCount() const { return clear_; }
On 2013/03/22 21:44:12, danakj wrote:
> clear_count()

Done.

https://codereview.chromium.org/12924003/diff/1/cc/output/gl_renderer_unittes...
cc/output/gl_renderer_unittest.cc:646: void
SetLastCallWasSetVisibilityPointer(bool* last_call_was_set_visibility) {
On 2013/03/22 21:44:12, danakj wrote:
> set_last_call_was..

Done.

https://codereview.chromium.org/12924003/diff/1/cc/output/gl_renderer_unittes...
cc/output/gl_renderer_unittest.cc:706: WGC3Denum ActiveTexture() const { return
active_texture_; }
On 2013/03/22 21:44:12, danakj wrote:
> active_texture()

Done.

[commit-bot: I haz the power, 2013-03-22 23:25:17]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ernstm@chromium.org/12924003/4001

[commit-bot: I haz the power, 2013-03-23 15:51:18]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ernstm@chromium.org/12924003/4001

[commit-bot: I haz the power, 2013-03-24 06:46:18]

Change committed as 190219