chrome/browser/ui/cocoa/browser_window_cocoa.mm - Issue 1292353006: Mac Changes for BubbleManager

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/browser_window_cocoa.mm

Issue 1292353006: Mac Changes for BubbleManager (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@mcdb-mac-3.gitbr

Patch Set: New upstream Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/cocoa/browser_window_cocoa.mm

diff --git a/chrome/browser/ui/cocoa/browser_window_cocoa.mm b/chrome/browser/ui/cocoa/browser_window_cocoa.mm

index 00357d6175ce39282020a2bca4d0a262938cc25e..97642d61bd8fee346dc8986a4a6fe039b619c8d3 100644

--- a/chrome/browser/ui/cocoa/browser_window_cocoa.mm

+++ b/chrome/browser/ui/cocoa/browser_window_cocoa.mm

@@ -711,7 +711,7 @@ bool BrowserWindowCocoa::PreHandleKeyboardEvent(

// Handle ESC to dismiss permission bubbles, but still forward it

// to the window afterwards.

if (event.windowsKeyCode == ui::VKEY_ESCAPE)

- [controller_ dismissPermissionBubble];

+ [controller_ dismissBubble];

if (![BrowserWindowUtils shouldHandleKeyboardEvent:event])

return false;