chrome/browser/ui/chrome_bubble_manager.cc - Issue 1292353006: Mac Changes for BubbleManager

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/chrome_bubble_manager.cc

Issue 1292353006: Mac Changes for BubbleManager (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@mcdb-mac-3.gitbr

Patch Set: New upstream Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/chrome_bubble_manager.cc

diff --git a/chrome/browser/ui/chrome_bubble_manager.cc b/chrome/browser/ui/chrome_bubble_manager.cc

index 62c3f685370288adb73869cc251e270876d6a664..400a1dbd9ca53008ea49802d4f60cb7bce3bf2d0 100644

--- a/chrome/browser/ui/chrome_bubble_manager.cc

+++ b/chrome/browser/ui/chrome_bubble_manager.cc

@@ -99,3 +99,12 @@ void ChromeBubbleManager::NavigationEntryCommitted(

void ChromeBubbleManager::WebContentsDestroyed(content::WebContents* context) {

CloseMatchingBubbles(context, FORCE_CLOSE, BUBBLE_CLOSE_IGNORE);

}

+void ChromeBubbleManager::UpdateAnchorPosition(content::WebContents* context) {

+ MassUpdateBubbles(context, base::Bind(&ChromeBubbleManager::UpdateBubbleUI,

+ this->AsWeakPtr()));

+void ChromeBubbleManager::UserDismissBubbles(content::WebContents* context) {

+ CloseMatchingBubbles(context, FORCE_CLOSE, BUBBLE_CLOSE_CLOSE);