Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1292163005: valueForLength() cannot do anything with min-intrinsic. (Closed)

Created:
5 years, 4 months ago by mstensho (USE GERRIT)
Modified:
5 years, 4 months ago
CC:
blink-reviews, blink-reviews-rendering, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Target Ref:
refs/remotes/origin/master
Project:
blink
Visibility:
Public.

Description

valueForLength() cannot do anything with min-intrinsic. Length::intrinsic() doesn't return true for min-intrinsic. isLegacyIntrinsic() does. But use isIntrinsicOrAuto() to catch both intrinsic, legacy-intrinsic and auto values, since that seems to be a rather popular way of doing things. Nobody seems to call isLegacyIntrinsic() directly. Regarding auto values here, it doesn't really matter whether we call valueForLength() or not, since they'll resolve to 0 anyway. BUG=521526 R=leviw@chromium.org,robhogan@gmail.com Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200695

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -1 line) Patch
A LayoutTests/fast/table/cell-height-min-intrinsic.html View 1 chunk +14 lines, -0 lines 0 comments Download
A LayoutTests/fast/table/cell-height-min-intrinsic-expected.txt View 1 chunk +3 lines, -0 lines 0 comments Download
M Source/core/layout/LayoutTableCell.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 16 (7 generated)
mstensho (USE GERRIT)
5 years, 4 months ago (2015-08-17 12:23:15 UTC) #2
leviw_travelin_and_unemployed
I'm sheriffing, so I'm spreading the love.
5 years, 4 months ago (2015-08-17 20:20:56 UTC) #4
cbiesinger
lgtm
5 years, 4 months ago (2015-08-17 21:13:58 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1292163005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1292163005/1
5 years, 4 months ago (2015-08-17 21:14:24 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/99268)
5 years, 4 months ago (2015-08-17 22:30:35 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1292163005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1292163005/1
5 years, 4 months ago (2015-08-17 22:45:28 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/99354)
5 years, 4 months ago (2015-08-18 01:32:33 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1292163005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1292163005/1
5 years, 4 months ago (2015-08-18 01:45:16 UTC) #15
commit-bot: I haz the power
5 years, 4 months ago (2015-08-18 04:40:12 UTC) #16
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=200695

Powered by Google App Engine
This is Rietveld 408576698