Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(301)

Issue 129203002: GM: run mode comparisons for all raster configs. (Closed)

Created:
6 years, 11 months ago by mtklein
Modified:
6 years, 11 months ago
Reviewers:
epoger, reed1
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

GM: run mode comparisons for all raster configs. GM works like this today: - Test all enabled configs directly - Render into 8888 - Test all enabled modes against that 8888. This change makes it do this: - Test all enabled configs directly - for each config, if it's raster, test all enabled modes against its output. Upshot is, we now check that picture draws identically to raster for 565 too, not just 8888. optimizations-565 is correctly failing. BUG=skia:1994 Committed: http://code.google.com/p/skia/source/detail?r=13050

Patch Set 1 #

Total comments: 5

Patch Set 2 : new expected test count calculation, update self test #

Patch Set 3 : rebaselining GM self-test on my Linux machine #

Total comments: 1

Patch Set 4 : new selftest1-pipe.png files I forgot to add last time #

Patch Set 5 : add RecordSkippedTest() for a single renderMode #

Total comments: 1

Patch Set 6 : make RecordSkippedTest() skip ALL renderModes for raster backends #

Total comments: 1

Patch Set 7 : update GM self-test results #

Total comments: 2

Patch Set 8 : pointer becomes ref #

Unified diffs Side-by-side diffs Delta from patch set Stats (+215 lines, -158 lines) Patch
M gm/gmmain.cpp View 1 2 3 4 5 6 7 6 chunks +184 lines, -134 lines 0 comments Download
M gm/tests/outputs/add-config-pdf/output-expected/stdout View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M gm/tests/outputs/checksum-based-filenames/output-expected/stdout View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M gm/tests/outputs/compared-against-different-pixels-images/output-expected/stdout View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M gm/tests/outputs/compared-against-different-pixels-json/output-expected/stdout View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M gm/tests/outputs/compared-against-empty-dir/output-expected/stdout View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M gm/tests/outputs/compared-against-identical-bytes-images/output-expected/stdout View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M gm/tests/outputs/compared-against-identical-bytes-json/output-expected/stdout View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M gm/tests/outputs/compared-against-identical-pixels-images/output-expected/stdout View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M gm/tests/outputs/compared-against-identical-pixels-json/output-expected/stdout View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M gm/tests/outputs/ignore-expectations-mismatch/output-expected/stdout View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M gm/tests/outputs/ignoring-one-test/output-expected/stdout View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M gm/tests/outputs/ignoring-some-failures/output-expected/stdout View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M gm/tests/outputs/intentionally-skipped-tests/output-expected/stdout View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M gm/tests/outputs/no-hierarchy/output-expected/stdout View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M gm/tests/outputs/no-readpath/output-expected/stdout View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M gm/tests/outputs/pipe-playback-failure/output-expected/json-summary.txt View 1 2 chunks +10 lines, -3 lines 0 comments Download
A + gm/tests/outputs/pipe-playback-failure/output-expected/mismatchPath/565/selftest1-pipe.png View 1 2 3 Binary file 0 comments Download
A + gm/tests/outputs/pipe-playback-failure/output-expected/mismatchPath/8888/selftest1-pipe.png View 1 2 3 Binary file 0 comments Download
M gm/tests/outputs/pipe-playback-failure/output-expected/stderr View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M gm/tests/outputs/pipe-playback-failure/output-expected/stdout View 1 2 3 4 5 6 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 28 (0 generated)
mtklein
https://codereview.chromium.org/129203002/diff/1/gm/gmmain.cpp File gm/gmmain.cpp (right): https://codereview.chromium.org/129203002/diff/1/gm/gmmain.cpp#newcode1777 gm/gmmain.cpp:1777: // TODO: run only if gmmain.test_drawing succeeded. The diff ...
6 years, 11 months ago (2014-01-08 20:05:53 UTC) #1
mtklein
On 2014/01/08 20:05:53, mtklein wrote: > https://codereview.chromium.org/129203002/diff/1/gm/gmmain.cpp > File gm/gmmain.cpp (right): > > https://codereview.chromium.org/129203002/diff/1/gm/gmmain.cpp#newcode1777 > ...
6 years, 11 months ago (2014-01-08 20:09:12 UTC) #2
epoger
looking now
6 years, 11 months ago (2014-01-08 20:13:18 UTC) #3
epoger
I like how you made the change. Questions/concerns below... https://codereview.chromium.org/129203002/diff/1/gm/gmmain.cpp File gm/gmmain.cpp (right): https://codereview.chromium.org/129203002/diff/1/gm/gmmain.cpp#newcode1777 gm/gmmain.cpp:1777: ...
6 years, 11 months ago (2014-01-08 20:48:54 UTC) #4
reed1
defers to epoger
6 years, 11 months ago (2014-01-08 20:49:43 UTC) #5
epoger
On 2014/01/08 20:49:43, reed1 wrote: > defers to epoger Nice try. Defers to reed on ...
6 years, 11 months ago (2014-01-08 20:51:06 UTC) #6
reed1
I think we either drop 565 from our tests, or we need this sort of ...
6 years, 11 months ago (2014-01-08 20:53:51 UTC) #7
epoger
On 2014/01/08 20:53:51, reed1 wrote: > I think we either drop 565 from our tests, ...
6 years, 11 months ago (2014-01-08 20:55:53 UTC) #8
mtklein
On 2014/01/08 20:53:51, reed1 wrote: > I think we either drop 565 from our tests, ...
6 years, 11 months ago (2014-01-08 21:07:12 UTC) #9
mtklein
On 2014/01/08 21:07:12, mtklein wrote: > On 2014/01/08 20:53:51, reed1 wrote: > > I think ...
6 years, 11 months ago (2014-01-08 21:53:39 UTC) #10
epoger
Uploaded patchset 3, after running gm/tests/rebaseline.sh on my Ubiquity instance. I'm not sure why expectedNumberOfTests ...
6 years, 11 months ago (2014-01-09 16:40:36 UTC) #11
mtklein
On 2014/01/09 16:40:36, epoger wrote: > Uploaded patchset 3, after running gm/tests/rebaseline.sh on my Ubiquity ...
6 years, 11 months ago (2014-01-09 16:56:13 UTC) #12
epoger
As of patchset 4, RunGmSelfTests passes on http://108.170.217.252:10117/builders/Housekeeper-PerCommit-Trybot/builds/17 Still waiting for http://108.170.217.252:10117/builders/Test-Ubuntu12-ShuttleA-ATI5770-x86-Debug-Trybot/builds/73 (tried at patchset ...
6 years, 11 months ago (2014-01-09 18:20:09 UTC) #13
epoger
On 2014/01/09 18:20:09, epoger wrote: > As of patchset 4, RunGmSelfTests passes on > http://108.170.217.252:10117/builders/Housekeeper-PerCommit-Trybot/builds/17 ...
6 years, 11 months ago (2014-01-09 20:23:09 UTC) #14
epoger
When I patched this CL onto my Mac laptop, I was able to reproduce the ...
6 years, 11 months ago (2014-01-09 22:12:35 UTC) #15
epoger
On 2014/01/09 22:12:35, epoger wrote: > GM: expected 5580 tests, but ran or skipped 5496 ...
6 years, 11 months ago (2014-01-09 22:15:51 UTC) #16
epoger
I was able to narrow it down: epoger-macbookpro2:skia epoger$ out/Debug/gm --verbose --writeChecksumBasedFilenames --ignoreErrorTypes IntentionallySkipped MissingExpectations ...
6 years, 11 months ago (2014-01-09 22:27:56 UTC) #17
epoger
> If I run with "--match twopointconical" or "--match shallow_gradient_conical", > it runs 20 tests ...
6 years, 11 months ago (2014-01-09 22:32:23 UTC) #18
epoger
https://codereview.chromium.org/129203002/diff/440001/gm/gmmain.cpp File gm/gmmain.cpp (right): https://codereview.chromium.org/129203002/diff/440001/gm/gmmain.cpp#newcode1167 gm/gmmain.cpp:1167: RecordSkippedTest(shortNamePlusConfig, Patchset 5: created a new RecordSkippedTest() method, to ...
6 years, 11 months ago (2014-01-10 19:36:38 UTC) #19
epoger
Patchset 6 fixes the count mismatch. I have to make one more patchset to rebaseline ...
6 years, 11 months ago (2014-01-10 20:53:26 UTC) #20
epoger
mtklein, this should finally be finished at patchset 7. PTAL. I will run it through ...
6 years, 11 months ago (2014-01-10 21:04:20 UTC) #21
mtklein
On 2014/01/10 21:04:20, epoger wrote: > mtklein, this should finally be finished at patchset 7. ...
6 years, 11 months ago (2014-01-10 22:11:24 UTC) #22
mtklein
oops, forgot to send the stumbling point :) https://codereview.chromium.org/129203002/diff/540001/gm/gmmain.cpp File gm/gmmain.cpp (right): https://codereview.chromium.org/129203002/diff/540001/gm/gmmain.cpp#newcode2335 gm/gmmain.cpp:2335: SkString ...
6 years, 11 months ago (2014-01-10 22:11:42 UTC) #23
epoger
https://codereview.chromium.org/129203002/diff/540001/gm/gmmain.cpp File gm/gmmain.cpp (right): https://codereview.chromium.org/129203002/diff/540001/gm/gmmain.cpp#newcode2335 gm/gmmain.cpp:2335: SkString *shortNamePlusConfig = &gmmain.fTestsSkippedOnAllRenderModes[testNum]; On 2014/01/10 22:11:43, mtklein wrote: ...
6 years, 11 months ago (2014-01-12 21:13:23 UTC) #24
epoger
verbal LGTM from mtklein
6 years, 11 months ago (2014-01-13 18:07:23 UTC) #25
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@google.com/129203002/620001
6 years, 11 months ago (2014-01-13 18:07:42 UTC) #26
commit-bot: I haz the power
Change committed as 13050
6 years, 11 months ago (2014-01-13 18:28:09 UTC) #27
epoger
6 years, 11 months ago (2014-01-13 21:08:53 UTC) #28
Message was sent while issue was closed.
Followup on performance difference after this change went in.  It’s definitely
slower, but the build times are noisy enough that it’s hard to say how MUCH
slower.


Android-NexusS-SGX540-Arm7-Debug : I don’t know what to make of this one
  before:
http://108.170.217.252:10117/builders/Test-Android-NexusS-SGX540-Arm7-Debug/b...
          kept reporting Out of Memory, took 1433 sec
 after:
http://108.170.217.252:10117/builders/Test-Android-NexusS-SGX540-Arm7-Debug/b...
        kept reporting Out of Memory, took 1611 sec

ChromeOS-Link-HD4000-x86_64-Debug : got 13% FASTER (?!)
  before:
http://108.170.217.252:10117/builders/Test-ChromeOS-Link-HD4000-x86_64-Debug/...
          ran 1092 tests in 171 sec
  after:
http://108.170.217.252:10117/builders/Test-ChromeOS-Link-HD4000-x86_64-Debug/...
         ran 1365 tests in 149 sec

Mac10.6-MacMini4.1-GeForce320M-x86_64-Debug : got 30% slower
  before:
http://108.170.217.252:10117/builders/Test-Mac10.6-MacMini4.1-GeForce320M-x86...
          ran 3601 tests in 765 sec
  after:
http://108.170.217.252:10117/builders/Test-Mac10.6-MacMini4.1-GeForce320M-x86...
         ran 5540 tests in 988 sec

Ubuntu12-ShuttleA-ATI5770-x86_64-Debug : got 31% slower
  before:
http://108.170.217.252:10117/builders/Test-Ubuntu12-ShuttleA-ATI5770-x86_64-D...
          ran 3601 tests in 413 sec
  after:
http://108.170.217.252:10117/builders/Test-Ubuntu12-ShuttleA-ATI5770-x86_64-D...
         ran 5540 tests in 542 sec

Win7-ShuttleA-HD2000-x86_64-Debug : got 8% slower
  before:
http://108.170.217.252:10117/builders/Test-Win7-ShuttleA-HD2000-x86_64-Debug/...
          ran 1946 tests in 213 sec
  after:
http://108.170.217.252:10117/builders/Test-Win7-ShuttleA-HD2000-x86_64-Debug/...
         ran 2224 tests in 231 sec

Powered by Google App Engine
This is Rietveld 408576698