Allow recording individual samples in addition to the aggregated CPU profiles

Allow recording individual samples in addition to the aggregated CPU profiles

CPU profiler API is extended with methods that allow to retrieve individual samples from profile. Each sample is presented as a pointer to a node in the top-down profile tree. The samples will let us tie JS performance to time.

BUG=None

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=13980

[loislo, 2013-03-18 12:56:39]

https://codereview.chromium.org/12919002/diff/1/src/profile-generator.cc
File src/profile-generator.cc (right):

https://codereview.chromium.org/12919002/diff/1/src/profile-generator.cc#newc...
src/profile-generator.cc:473: samples_.Add(top_frame_node);
it seems that you collect the samples regardless of the state of the flag.
Please fix that and add a test for that.

[yurys, 2013-03-18 12:58:08]

https://codereview.chromium.org/12919002/diff/1/src/profile-generator.cc
File src/profile-generator.cc (right):

https://codereview.chromium.org/12919002/diff/1/src/profile-generator.cc#newc...
src/profile-generator.cc:473: samples_.Add(top_frame_node);
On 2013/03/18 12:56:39, loislo wrote:
> it seems that you collect the samples regardless of the state of the flag.
> Please fix that and add a test for that.

Done.

[loislo, 2013-03-18 13:15:51]

On 2013/03/18 12:58:08, Yury Semikhatsky wrote:
> https://codereview.chromium.org/12919002/diff/1/src/profile-generator.cc
> File src/profile-generator.cc (right):
> 
>
https://codereview.chromium.org/12919002/diff/1/src/profile-generator.cc#newc...
> src/profile-generator.cc:473: samples_.Add(top_frame_node);
> On 2013/03/18 12:56:39, loislo wrote:
> > it seems that you collect the samples regardless of the state of the flag.
> > Please fix that and add a test for that.
> 
> Done.

lgtm

[Jakob Kummerow, 2013-03-18 17:18:08]

lgtm

https://codereview.chromium.org/12919002/diff/8001/test/cctest/test-profile-g...
File test/cctest/test-profile-generator.cc (right):

https://codereview.chromium.org/12919002/diff/8001/test/cctest/test-profile-g...
test/cctest/test-profile-generator.cc:721: CheckNodeIds(node->children()->at(i),
expectedId);
nit: indentation

[yurys, 2013-03-19 08:02:58]

https://codereview.chromium.org/12919002/diff/8001/test/cctest/test-profile-g...
File test/cctest/test-profile-generator.cc (right):

https://codereview.chromium.org/12919002/diff/8001/test/cctest/test-profile-g...
test/cctest/test-profile-generator.cc:721: CheckNodeIds(node->children()->at(i),
expectedId);
On 2013/03/18 17:18:08, Jakob wrote:
> nit: indentation

Done.

[yurys, 2013-03-19 08:12:30]

Committed patchset #5 manually as r13980.