Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(327)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1291873005: Removed unused CascadeOrder. (Closed)

Created:
5 years, 4 months ago by rune
Modified:
5 years, 4 months ago
Reviewers:
kochi
CC:
blink-reviews, blink-reviews-style_chromium.org, blink-reviews-css, dglazkov+blink, apavlov+blink_chromium.org, darktears, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@shadow-cascade-order-20150817
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Removed unused CascadeOrder. CascadeOrder is always ignoreCascadeOrder after [1] and can be removed. [1] https://codereview.chromium.org/1298173004 BUG=487125 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201019

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -35 lines) Patch
M Source/core/css/ElementRuleCollector.h View 3 chunks +6 lines, -11 lines 0 comments Download
M Source/core/css/ElementRuleCollector.cpp View 7 chunks +15 lines, -15 lines 0 comments Download
M Source/core/css/resolver/ScopedStyleResolver.h View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/css/resolver/ScopedStyleResolver.cpp View 2 chunks +6 lines, -6 lines 0 comments Download

Depends on Patchset:

Issue 1298173004 Patch 1

Messages

Total messages: 13 (5 generated)
rune
Split out from https://codereview.chromium.org/1224673002/ Applied on top of https://codereview.chromium.org/1298173004/
5 years, 4 months ago (2015-08-18 13:30:39 UTC) #2
rune
5 years, 4 months ago (2015-08-18 13:32:24 UTC) #4
kochi
rs lgtm Once the dependent patch is landed, this change is obviously correct.
5 years, 4 months ago (2015-08-19 10:36:57 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1291873005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1291873005/1
5 years, 4 months ago (2015-08-21 17:27:20 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator_ninja/builds/59851)
5 years, 4 months ago (2015-08-21 17:29:45 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1291873005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1291873005/1
5 years, 4 months ago (2015-08-21 18:34:17 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://src.chromium.org/viewvc/blink?view=rev&revision=201019
5 years, 4 months ago (2015-08-21 22:04:46 UTC) #12
jianli
5 years, 4 months ago (2015-08-25 00:35:48 UTC) #13
Message was sent while issue was closed. 
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1306693007/ by jianli@chromium.org.

The reason for reverting is: Speculative revert for causing "Too many opened
files in the system".

https://code.google.com/p/chromium/issues/detail?id=523598
.

Powered by Google App Engine
This is Rietveld 408576698