Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(370)

Unified Diff: components/variations/variations_experiment_util.h

Issue 1291763002: Componentize kExperimentLabelSeparator & BuildExperimentDateString. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Try moving kExperimentLabels into the component to fix the build on Windows Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/variations/variations_experiment_util.h
diff --git a/chrome/installer/util/google_update_experiment_util.h b/components/variations/variations_experiment_util.h
similarity index 70%
rename from chrome/installer/util/google_update_experiment_util.h
rename to components/variations/variations_experiment_util.h
index e969376c8c6d05292465f959d4a87b410c2353b8..126f30a2cc44843e8a1f6fecc83be5830fb6c2c1 100644
--- a/chrome/installer/util/google_update_experiment_util.h
+++ b/components/variations/variations_experiment_util.h
@@ -2,8 +2,8 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-#ifndef CHROME_INSTALLER_UTIL_GOOGLE_UPDATE_EXPERIMENT_UTIL_H_
-#define CHROME_INSTALLER_UTIL_GOOGLE_UPDATE_EXPERIMENT_UTIL_H_
+#ifndef COMPONENTS_VARIATIONS_VARIATIONS_EXPERIMENT_UTIL_H_
+#define COMPONENTS_VARIATIONS_VARIATIONS_EXPERIMENT_UTIL_H_
#include "base/strings/string16.h"
@@ -11,7 +11,7 @@ namespace base {
class Time;
}
-namespace google_update {
+namespace variations {
#if defined(OS_WIN)
// The name of the value where Google Update reads the list of experiments for
@@ -22,14 +22,10 @@ extern const wchar_t kExperimentLabels[];
// The separator used to separate items in kExperimentLabels.
extern const base::char16 kExperimentLabelSeparator;
-} // namespace google_update
-
-namespace installer {
-
// Constructs a date string in the format understood by Google Update for the
// |current_time| plus one year.
base::string16 BuildExperimentDateString(const base::Time& current_time);
-} // namespace installer
+} // namespace variations
-#endif // CHROME_INSTALLER_UTIL_GOOGLE_UPDATE_EXPERIMENT_UTIL_H_
+#endif // COMPONENTS_VARIATIONS_VARIATIONS_EXPERIMENT_UTIL_H_

Powered by Google App Engine
This is Rietveld 408576698