Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Unified Diff: components/variations/variations_experiment_util.cc

Issue 1291763002: Componentize kExperimentLabelSeparator & BuildExperimentDateString. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Try moving kExperimentLabels into the component to fix the build on Windows Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/variations/variations_experiment_util.cc
diff --git a/chrome/installer/util/google_update_experiment_util.cc b/components/variations/variations_experiment_util.cc
similarity index 90%
rename from chrome/installer/util/google_update_experiment_util.cc
rename to components/variations/variations_experiment_util.cc
index 2bff96f54847750f6f539a838539fe383dea9b7a..569a11ef7d477e02c8c25e5e1fda9da414b62683 100644
--- a/chrome/installer/util/google_update_experiment_util.cc
+++ b/components/variations/variations_experiment_util.cc
@@ -2,7 +2,7 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-#include "chrome/installer/util/google_update_experiment_util.h"
+#include "components/variations/variations_experiment_util.h"
#include <vector>
@@ -11,7 +11,7 @@
#include "base/strings/utf_string_conversions.h"
#include "base/time/time.h"
-namespace google_update {
+namespace variations {
#if defined(OS_WIN)
const wchar_t kExperimentLabels[] = L"experiment_labels";
@@ -19,10 +19,6 @@ const wchar_t kExperimentLabels[] = L"experiment_labels";
const base::char16 kExperimentLabelSeparator = ';';
-} // namespace google_update
-
-namespace installer {
-
namespace {
const char* const kDays[] =
@@ -32,7 +28,7 @@ const char* const kMonths[] =
{ "Jan", "Feb", "Mar", "Apr", "May", "Jun", "Jul", "Aug", "Sep",
"Oct", "Nov", "Dec"};
-}
+} // namespace
base::string16 BuildExperimentDateString(const base::Time& current_time) {
// The Google Update experiment_labels timestamp format is:
@@ -61,5 +57,4 @@ base::string16 BuildExperimentDateString(const base::Time& current_time) {
then.second));
}
-} // namespace installer
-
+} // namespace variations

Powered by Google App Engine
This is Rietveld 408576698