Issue 12917002: Pass Isolates explicitly in Deoptimizer-related code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12917002: Pass Isolates explicitly in Deoptimizer-related code. (Closed)

Created:
7 years, 9 months ago by Sven Panne

Modified:
7 years, 9 months ago

Reviewers:
Toon Verwaest

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Pass Isolates explicitly in Deoptimizer-related code. Removed a few ancient useless ASSERTs on the way. Reduced the number of train wrecks. BUG=v8:2487 Committed: http://code.google.com/p/v8/source/detail?r=13965

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+122 lines, -106 lines)			Patch
M	src/api.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/arm/lithium-codegen-arm.cc	View		2 chunks	+3 lines, -2 lines	0 comments	Download
M	src/assembler.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/assembler.cc	View		2 chunks	+3 lines, -3 lines	0 comments	Download
M	src/debug.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/deoptimizer.h	View	1	7 chunks	+13 lines, -6 lines	0 comments	Download
M	src/deoptimizer.cc	View	1	16 chunks	+43 lines, -55 lines	0 comments	Download
M	src/disassembler.cc	View		1 chunk	+6 lines, -2 lines	0 comments	Download
M	src/ia32/lithium-codegen-ia32.cc	View		2 chunks	+3 lines, -2 lines	0 comments	Download
M	src/isolate.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/liveedit.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/log.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/mark-compact.h	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/mark-compact.cc	View	1	13 chunks	+21 lines, -16 lines	0 comments	Download
M	src/mips/lithium-codegen-mips.cc	View		2 chunks	+3 lines, -2 lines	0 comments	Download
M	src/objects.h	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	src/objects.cc	View	1	4 chunks	+6 lines, -3 lines	0 comments	Download
M	src/objects-inl.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	src/x64/lithium-codegen-x64.cc	View		2 chunks	+3 lines, -2 lines	0 comments	Download
M	test/cctest/test-debug.cc	View		5 chunks	+7 lines, -5 lines	0 comments	Download

Total messages: 3 (0 generated)

Sven Panne

7 years, 9 months ago (2013-03-18 13:59:08 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r13965 (presubmit successful).