Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Side by Side Diff: src/debug.cc

Issue 12917002: Pass Isolates explicitly in Deoptimizer-related code. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Cleanup Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/assembler.cc ('k') | src/deoptimizer.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 1982 matching lines...) Expand 10 before | Expand all | Expand 10 after
1993 void VisitThread(Isolate* isolate, ThreadLocalTop* top) { 1993 void VisitThread(Isolate* isolate, ThreadLocalTop* top) {
1994 RedirectActivationsToRecompiledCodeOnThread(isolate, top); 1994 RedirectActivationsToRecompiledCodeOnThread(isolate, top);
1995 } 1995 }
1996 }; 1996 };
1997 1997
1998 1998
1999 void Debug::PrepareForBreakPoints() { 1999 void Debug::PrepareForBreakPoints() {
2000 // If preparing for the first break point make sure to deoptimize all 2000 // If preparing for the first break point make sure to deoptimize all
2001 // functions as debugging does not work with optimized code. 2001 // functions as debugging does not work with optimized code.
2002 if (!has_break_points_) { 2002 if (!has_break_points_) {
2003 Deoptimizer::DeoptimizeAll(); 2003 Deoptimizer::DeoptimizeAll(isolate_);
2004 2004
2005 Handle<Code> lazy_compile = 2005 Handle<Code> lazy_compile =
2006 Handle<Code>(isolate_->builtins()->builtin(Builtins::kLazyCompile)); 2006 Handle<Code>(isolate_->builtins()->builtin(Builtins::kLazyCompile));
2007 2007
2008 // There will be at least one break point when we are done. 2008 // There will be at least one break point when we are done.
2009 has_break_points_ = true; 2009 has_break_points_ = true;
2010 2010
2011 // Keep the list of activated functions in a handlified list as it 2011 // Keep the list of activated functions in a handlified list as it
2012 // is used both in GC and non-GC code. 2012 // is used both in GC and non-GC code.
2013 List<Handle<JSFunction> > active_functions(100); 2013 List<Handle<JSFunction> > active_functions(100);
(...skipping 1781 matching lines...) Expand 10 before | Expand all | Expand 10 after
3795 { 3795 {
3796 Locker locker(reinterpret_cast<v8::Isolate*>(isolate)); 3796 Locker locker(reinterpret_cast<v8::Isolate*>(isolate));
3797 isolate->debugger()->CallMessageDispatchHandler(); 3797 isolate->debugger()->CallMessageDispatchHandler();
3798 } 3798 }
3799 } 3799 }
3800 } 3800 }
3801 3801
3802 #endif // ENABLE_DEBUGGER_SUPPORT 3802 #endif // ENABLE_DEBUGGER_SUPPORT
3803 3803
3804 } } // namespace v8::internal 3804 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/assembler.cc ('k') | src/deoptimizer.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698