Oilpan: Fix a raw reference in FramePainter.

Oilpan: Fix a raw reference in FramePainter.

All the uses of FramePainter are on stack, hence STACK_ALLOCATED(). Added
WTF_MAKE_NONCOPYABLE() as a bonus.

BUG=509911
R=haraken@chromium.org, keishi@chromium.org, oilpan-reviews@chromium.org

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200636

[haraken, 2015-08-12 05:25:55]

LGTM

https://codereview.chromium.org/1291673002/diff/1/Source/core/paint/FramePain...
File Source/core/paint/FramePainter.cpp (right):

https://codereview.chromium.org/1291673002/diff/1/Source/core/paint/FramePain...
Source/core/paint/FramePainter.cpp:32:
m_frameView->notifyPageThatContentAreaWillPaint();

tkent-san would prefer addding frameView(), which returns a reference.

https://codereview.chromium.org/1291673002/diff/1/Source/core/paint/FramePain...
File Source/core/paint/FramePainter.h (right):

https://codereview.chromium.org/1291673002/diff/1/Source/core/paint/FramePain...
Source/core/paint/FramePainter.h:22: FramePainter(FrameView& frameView) :
m_frameView(&frameView) { }

Add explicit.

[Yuta Kitamura, 2015-08-12 05:38:27]

https://codereview.chromium.org/1291673002/diff/1/Source/core/paint/FramePain...
File Source/core/paint/FramePainter.cpp (right):

https://codereview.chromium.org/1291673002/diff/1/Source/core/paint/FramePain...
Source/core/paint/FramePainter.cpp:32:
m_frameView->notifyPageThatContentAreaWillPaint();
On 2015/08/12 05:25:54, haraken wrote:
> 
> tkent-san would prefer addding frameView(), which returns a reference.

Yeah, that seems better. Done.

https://codereview.chromium.org/1291673002/diff/1/Source/core/paint/FramePain...
File Source/core/paint/FramePainter.h (right):

https://codereview.chromium.org/1291673002/diff/1/Source/core/paint/FramePain...
Source/core/paint/FramePainter.h:22: FramePainter(FrameView& frameView) :
m_frameView(&frameView) { }
On 2015/08/12 05:25:54, haraken wrote:
> 
> Add explicit.

Done.

[Yuta Kitamura, 2015-08-14 06:31:42]

The CQ bit was checked by yutak@chromium.org

[Yuta Kitamura, 2015-08-14 06:31:42]

The patchset sent to the CQ was uploaded after l-g-t-m from haraken@chromium.org
Link to the patchset: https://codereview.chromium.org/1291673002/#ps20001
(title: "Add explicit; introduce frameView().")

[commit-bot: I haz the power, 2015-08-14 06:32:01]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1291673002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1291673002/20001

[commit-bot: I haz the power, 2015-08-14 07:59:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-08-14 07:59:48]

Try jobs failed on following builders:
  win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[Yuta Kitamura, 2015-08-17 08:21:11]

The CQ bit was checked by yutak@chromium.org

[commit-bot: I haz the power, 2015-08-17 08:21:24]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1291673002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1291673002/20001

[commit-bot: I haz the power, 2015-08-17 09:23:37]

Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=200636