Issue 1291573004: Use EXPECT_STREQ(a, b) when a and b are both const char*

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1291573004: Use EXPECT_STREQ(a, b) when a and b are both const char* (Closed)

Created:
5 years, 4 months ago by Mark Mentovai

Modified:
5 years, 4 months ago

Reviewers:
Robert Sesek

CC:
crashpad-dev_chromium.org

Base URL:
https://chromium.googlesource.com/crashpad/crashpad@master

Target Ref:
refs/heads/master

Project:
crashpad

Visibility:
Public.

Use EXPECT_STREQ(a, b) when a and b are both const char* While not strictly asan-related, this bug was found while running tests under asan. Evidently, strings are pooled differently in that build configuration. TEST=crashpad_util_test ExceptionPorts.* R=rsesek@chromium.org Committed: https://chromium.googlesource.com/crashpad/crashpad/+/b1d78336004e42cb759e65e1b3ed539897b5215f

Created: 5 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -5 lines)			Patch
	M	util/mach/exception_ports_test.cc	View		4 chunks	+5 lines, -5 lines	0 comments	Download

Total messages: 4 (1 generated)

Mark Mentovai

5 years, 4 months ago (2015-08-19 22:47:58 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
b1d78336004e42cb759e65e1b3ed539897b5215f (presubmit successful).