Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(329)

Unified Diff: util/mach/exception_ports_test.cc

Issue 1291573004: Use EXPECT_STREQ(a, b) when a and b are both const char* (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: util/mach/exception_ports_test.cc
diff --git a/util/mach/exception_ports_test.cc b/util/mach/exception_ports_test.cc
index 6081c02def806fc6c012fbd35e8f700d90c515e2..4ab925384805fbfbad79f6480231d3cd0ed82a24 100644
--- a/util/mach/exception_ports_test.cc
+++ b/util/mach/exception_ports_test.cc
@@ -361,7 +361,7 @@ class TestExceptionPorts : public MachMultiprocess,
// Get an ExceptionPorts object for the task and each of its threads.
ExceptionPorts task_ports(ExceptionPorts::kTargetTypeTask, ChildTask());
- EXPECT_EQ("task", task_ports.TargetTypeName());
+ EXPECT_STREQ("task", task_ports.TargetTypeName());
// Hopefully the threads returned by task_threads() are in order, with the
// main thread first and the other thread second. This is currently always
@@ -381,8 +381,8 @@ class TestExceptionPorts : public MachMultiprocess,
main_thread);
ExceptionPorts other_thread_ports(ExceptionPorts::kTargetTypeThread,
other_thread);
- EXPECT_EQ("thread", main_thread_ports.TargetTypeName());
- EXPECT_EQ("thread", other_thread_ports.TargetTypeName());
+ EXPECT_STREQ("thread", main_thread_ports.TargetTypeName());
+ EXPECT_STREQ("thread", other_thread_ports.TargetTypeName());
if (set_type_ == kSetOutOfProcess) {
// Test ExceptionPorts::SetExceptionPorts() being called from
@@ -587,7 +587,7 @@ TEST(ExceptionPorts, HostExceptionPorts) {
base::mac::ScopedMachSendRight host(mach_host_self());
ExceptionPorts explicit_host_ports(ExceptionPorts::kTargetTypeHost, host);
- EXPECT_EQ("host", explicit_host_ports.TargetTypeName());
+ EXPECT_STREQ("host", explicit_host_ports.TargetTypeName());
std::vector<ExceptionPorts::ExceptionHandler> handlers;
bool rv = explicit_host_ports.GetExceptionPorts(
@@ -600,7 +600,7 @@ TEST(ExceptionPorts, HostExceptionPorts) {
ExceptionPorts implicit_host_ports(ExceptionPorts::kTargetTypeHost,
HOST_NULL);
- EXPECT_EQ("host", implicit_host_ports.TargetTypeName());
+ EXPECT_STREQ("host", implicit_host_ports.TargetTypeName());
rv = implicit_host_ports.GetExceptionPorts(
ExcMaskAll() | EXC_MASK_CRASH, &handlers);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698