Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4597)

Unified Diff: chrome/browser/web_resource/promo_resource_service.cc

Issue 1291543004: Inject JSON parsing in WebResource as a callback rather than inheritance (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@webResources1
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/web_resource/promo_resource_service.cc
diff --git a/chrome/browser/web_resource/promo_resource_service.cc b/chrome/browser/web_resource/promo_resource_service.cc
index abc63e4b003b826c6564ff91b7111dd4fca875e2..b4970db7e86ea5a4940de288ad6f8d58da7064ce 100644
--- a/chrome/browser/web_resource/promo_resource_service.cc
+++ b/chrome/browser/web_resource/promo_resource_service.cc
@@ -82,14 +82,23 @@ void PromoResourceService::MigrateUserPrefs(PrefService* user_prefs) {
NotificationPromo::MigrateUserPrefs(user_prefs);
}
-PromoResourceService::PromoResourceService(PrefService* local_state,
- version_info::Channel channel)
- : ChromeWebResourceService(local_state,
- GetPromoResourceURL(channel),
- true, // append locale to URL
- prefs::kNtpPromoResourceCacheUpdate,
- kStartResourceFetchDelay,
- GetCacheUpdateDelay()),
+PromoResourceService::PromoResourceService(
+ PrefService* local_state,
+ version_info::Channel channel,
+ const std::string& application_locale,
+ net::URLRequestContextGetter* request_context,
+ const char* disable_network_switch,
+ const ParseJSONCallback& parse_json_callback)
+ : web_resource::WebResourceService(
+ local_state,
+ GetPromoResourceURL(channel),
+ application_locale, // append locale to URL
+ prefs::kNtpPromoResourceCacheUpdate,
+ kStartResourceFetchDelay,
+ GetCacheUpdateDelay(),
+ request_context,
+ disable_network_switch,
+ parse_json_callback),
weak_ptr_factory_(this) {
ScheduleNotificationOnInit();
}

Powered by Google App Engine
This is Rietveld 408576698