Chromium Code Reviews Chromium Code Reviews
Issue
12915008:
Revert 189820 "Lazy initialize WGC3DInProcessCommandBufferImpl". Causing checkfailures. (Closed)
DescriptionRevert 189820 "Lazy initialize WGC3DInProcessCommandBufferImpl". Causing checkfailures.
> Lazy initialize WGC3DInProcessCommandBufferImpl
>
> WGC3DInProcessCommandBufferImpl will be used in Android WebView synchronous
> draw artchitecture, where directl GL calls can be made only inside the android
> GL draw functor.
>
> This patch moves the Intialize logic of WGC3DInProcessCommandBufferImpl to
> makeContextCurrent, so the initilization GL calls are delayed until inside
> the GL draw functor. This also allows WGC3DInProcessCommandBufferImpl to be
> created on one thread and be used on a different thread where it is made
> current. This is a requirement for using it in threaded compositor.
>
> Also some clean ups:
> Remove the parent view context param. NULL is passed in everywhere.
> Make the attribute param const ref.
> Folded Initialize into constructor.
>
> BUG=179436
>
> Review URL: https://codereview.chromium.org/12908004
TBR=boliu@chromium.org
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=189975
Patch Set 1 #
Messages
Total messages: 3 (0 generated)
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
