trunk/src/webkit/gpu/webgraphicscontext3d_in_process_command_buffer_impl.h - Issue 12915008: Revert 189820 "Lazy initialize WGC3DInProcessCommandBufferImpl". Causing checkfailures.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: trunk/src/webkit/gpu/webgraphicscontext3d_in_process_command_buffer_impl.h

Issue 12915008: Revert 189820 "Lazy initialize WGC3DInProcessCommandBufferImpl". Causing checkfailures. (Closed) Base URL: svn://svn.chromium.org/chrome/

Patch Set: Created 7 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « trunk/src/webkit/gpu/context_provider_in_process.cc ('k') | trunk/src/webkit/gpu/webgraphicscontext3d_in_process_command_buffer_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: trunk/src/webkit/gpu/webgraphicscontext3d_in_process_command_buffer_impl.h

===================================================================

--- trunk/src/webkit/gpu/webgraphicscontext3d_in_process_command_buffer_impl.h (revision 189974)

+++ trunk/src/webkit/gpu/webgraphicscontext3d_in_process_command_buffer_impl.h (working copy)

@@ -50,10 +50,12 @@

: public NON_EXPORTED_BASE(WebKit::WebGraphicsContext3D) {

public:

- WebGraphicsContext3DInProcessCommandBufferImpl(

- const WebKit::WebGraphicsContext3D::Attributes& attributes);

+ WebGraphicsContext3DInProcessCommandBufferImpl();

virtual ~WebGraphicsContext3DInProcessCommandBufferImpl();

+ bool Initialize(WebKit::WebGraphicsContext3D::Attributes attributes,

+ WebKit::WebGraphicsContext3D* view_context);

//----------------------------------------------------------------------

// WebGraphicsContext3D methods

virtual bool makeContextCurrent();

@@ -511,15 +513,10 @@

void OnSwapBuffersComplete();

virtual void OnContextLost();

- bool MaybeInitializeGL();

// Used to try to find bugs in code that calls gl directly through the gl api

// instead of going through WebGraphicsContext3D.

void ClearContext();

- bool initialized_;

- bool initialize_failed_;

// The context we use for OpenGL rendering.

GLInProcessContext* context_;

// The GLES2Implementation we use for OpenGL rendering.