Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Issue 1291203003: [Presentation API, Android] Implement routes observers (Closed)

Created:
5 years, 4 months ago by whywhat
Modified:
5 years, 4 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org, mcasas+watch_chromium.org, media-router+watch_chromium.org, posciak+watch_chromium.org, wjia+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@close-route
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Presentation API, Android] Implement routes observers BUG=517100 Committed: https://crrev.com/849d49aa4ecad9246680207c2fdc5791c07afcbc Cr-Commit-Position: refs/heads/master@{#344231}

Patch Set 1 #

Total comments: 7

Patch Set 2 : Switched from hash map to vector #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+74 lines, -16 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/media/router/ChromeMediaRouter.java View 6 chunks +33 lines, -3 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/media/router/cast/CreateRouteRequest.java View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/media/android/router/media_router_android.h View 1 3 chunks +9 lines, -3 lines 0 comments Download
M chrome/browser/media/android/router/media_router_android.cc View 1 5 chunks +30 lines, -8 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 18 (7 generated)
whywhat
PTaL
5 years, 4 months ago (2015-08-18 22:26:19 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1291203003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1291203003/1
5 years, 4 months ago (2015-08-18 22:26:59 UTC) #4
mlamouri (slow - plz ping)
lgtm with comments applied. https://codereview.chromium.org/1291203003/diff/1/chrome/browser/media/android/router/media_router_android.cc File chrome/browser/media/android/router/media_router_android.cc (right): https://codereview.chromium.org/1291203003/diff/1/chrome/browser/media/android/router/media_router_android.cc#newcode177 chrome/browser/media/android/router/media_router_android.cc:177: if (!routes_observers_.HasObserver(observer)) nit: I don't ...
5 years, 4 months ago (2015-08-18 22:39:37 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 4 months ago (2015-08-18 23:31:43 UTC) #7
whywhat
https://codereview.chromium.org/1291203003/diff/1/chrome/browser/media/android/router/media_router_android.cc File chrome/browser/media/android/router/media_router_android.cc (right): https://codereview.chromium.org/1291203003/diff/1/chrome/browser/media/android/router/media_router_android.cc#newcode177 chrome/browser/media/android/router/media_router_android.cc:177: if (!routes_observers_.HasObserver(observer)) On 2015/08/18 at 22:39:37, Mounir Lamouri wrote: ...
5 years, 4 months ago (2015-08-19 00:26:43 UTC) #8
whywhat
Rebase
5 years, 4 months ago (2015-08-19 13:54:26 UTC) #9
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1291203003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1291203003/40001
5 years, 4 months ago (2015-08-19 13:55:48 UTC) #11
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 4 months ago (2015-08-19 15:07:29 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1291203003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1291203003/40001
5 years, 4 months ago (2015-08-19 15:26:35 UTC) #16
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 4 months ago (2015-08-19 15:32:48 UTC) #17
commit-bot: I haz the power
5 years, 4 months ago (2015-08-19 15:33:39 UTC) #18
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/849d49aa4ecad9246680207c2fdc5791c07afcbc
Cr-Commit-Position: refs/heads/master@{#344231}

Powered by Google App Engine
This is Rietveld 408576698