chrome/android/java/src/org/chromium/chrome/browser/media/router/cast/CreateRouteRequest.java - Issue 1291203003: [Presentation API, Android] Implement routes observers

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/media/router/cast/CreateRouteRequest.java

Issue 1291203003: [Presentation API, Android] Implement routes observers (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@close-route

Patch Set: Rebase Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/media/router/ChromeMediaRouter.java ('k') | chrome/browser/media/android/router/media_router_android.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/media/router/cast/CreateRouteRequest.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/media/router/cast/CreateRouteRequest.java b/chrome/android/java/src/org/chromium/chrome/browser/media/router/cast/CreateRouteRequest.java

index 67d8091c4db4094e061275ce029c0e3ccc95f2d8..6d287867470ba4d7b57023acc5ac8f341e1e03ed 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/media/router/cast/CreateRouteRequest.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/media/router/cast/CreateRouteRequest.java

@@ -206,8 +206,8 @@ public class CreateRouteRequest implements GoogleApiClient.ConnectionCallbacks,

private void reportSuccess(String sessionId, boolean wasLaunched) {

if (mState != STATE_LAUNCH_SUCCEEDED) throwInvalidState();

- String mediaRouteId = String.format(

- "route:%s/%s/%s", mPresentationId, mSinkId, mSourceUrn);

+ String mediaRouteId = ChromeMediaRouter.createMediaRouteId(

+ mPresentationId, mSinkId, mSourceUrn);

mMediaRouter.onRouteCreated(

mediaRouteId, mRequestId, new SessionWrapper(mApiClient, sessionId), wasLaunched);