Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3054)

Unified Diff: chrome/browser/web_applications/web_app_mac.mm

Issue 12912003: [mac] Create app shortcuts in a subfolder of /Applications (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/web_applications/web_app_mac.mm
diff --git a/chrome/browser/web_applications/web_app_mac.mm b/chrome/browser/web_applications/web_app_mac.mm
index 2c6154800a6a4b4f57b95639328c727be7316053..b58e8f85ddaa9add7f7c889fffe8cc8a5174398e 100644
--- a/chrome/browser/web_applications/web_app_mac.mm
+++ b/chrome/browser/web_applications/web_app_mac.mm
@@ -85,6 +85,8 @@ bool AddBitmapImageRepToIconFamily(IconFamily* icon_family,
namespace web_app {
+const char kChromeAppDirName[] = "Chrome Apps.localized";
+
WebAppShortcutCreator::WebAppShortcutCreator(
const base::FilePath& user_data_dir,
const ShellIntegration::ShortcutInfo& shortcut_info,
@@ -120,6 +122,15 @@ bool WebAppShortcutCreator::CreateShortcut() {
return false;
base::FilePath dst_path = GetDestinationPath(app_file_name);
+ if (dst_path.empty()) {
+ LOG(ERROR) << "Couldn't find an Applications directory to copy app to.";
+ return false;
+ }
+ dst_path = dst_path.Append(kChromeAppDirName);
+ if (!file_util::CreateDirectory(dst_path)) {
+ LOG(ERROR) << "Creating directory " << dst_path.value() << " failed.";
+ return false;
+ }
if (!file_util::CopyDirectory(staging_path, dst_path, true)) {
LOG(ERROR) << "Copying app to dst path: " << dst_path.value() << " failed";
return false;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698