[mac] Create app shortcuts in a subfolder of /Applications

chrome/browser/web_applications/web_app_mac.mm

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "chrome/browser/web_applications/web_app_mac.h"
 
 #import <Cocoa/Cocoa.h>
 
 #include "base/file_util.h"
 #include "base/files/scoped_temp_dir.h"
@@ skipping 67 matching lines @@
     default:
       return false;
   }
 }
 
 }  // namespace
 
 
 namespace web_app {
 
+const char kChromeAppDirName[] = "Chrome Apps.localized";
+
 WebAppShortcutCreator::WebAppShortcutCreator(
     const base::FilePath& user_data_dir,
     const ShellIntegration::ShortcutInfo& shortcut_info,
     const string16& chrome_bundle_id)
     : user_data_dir_(user_data_dir),
       info_(shortcut_info),
       chrome_bundle_id_(chrome_bundle_id) {
 }
 
 WebAppShortcutCreator::~WebAppShortcutCreator() {
@@ skipping 15 matching lines @@
     return false;
   }
 
   if (!UpdatePlist(staging_path))
     return false;
 
   if (!UpdateIcon(staging_path))
     return false;
 
   base::FilePath dst_path = GetDestinationPath(app_file_name);
+  if (dst_path.empty()) {
+    LOG(ERROR) << "Couldn't find an Applications directory to copy app to.";
+    return false;
+  }
+  dst_path = dst_path.Append(kChromeAppDirName);
+  if (!file_util::CreateDirectory(dst_path)) {
+    LOG(ERROR) << "Creating directory " << dst_path.value() << " failed.";
+    return false;
+  }
   if (!file_util::CopyDirectory(staging_path, dst_path, true)) {
     LOG(ERROR) << "Copying app to dst path: " << dst_path.value() << " failed";
     return false;
   }
 
   dst_path = dst_path.Append(app_file_name);
   base::mac::RemoveQuarantineAttribute(dst_path);
   RevealGeneratedBundleInFinder(dst_path);
 
   return true;
 }
 
 base::FilePath WebAppShortcutCreator::GetAppLoaderPath() const {
   return base::mac::PathForFrameworkBundleResource(
       base::mac::NSToCFCast(@"app_mode_loader.app"));
 }
 
 base::FilePath WebAppShortcutCreator::GetDestinationPath(
     const base::FilePath& app_file_name) const {

[benwells, 2013/03/18 05:01:17]

Is there a reason this takes app_file_name?

   base::FilePath path;
   if (base::mac::GetLocalDirectory(NSApplicationDirectory, &path) &&
       file_util::PathIsWritable(path)) {
     return path;
   }
 
   if (base::mac::GetUserDirectory(NSApplicationDirectory, &path))
     return path;
 
   return base::FilePath();
@@ skipping 148 matching lines @@
 void UpdatePlatformShortcuts(
     const base::FilePath& web_app_path,
     const ShellIntegration::ShortcutInfo& shortcut_info) {
   // TODO(benwells): Implement this when shortcuts / weblings are enabled on
   // mac.
 }
 
 }  // namespace internals
 
 }  // namespace web_app