Remove support for product attributes in Android xml files.

Remove support for product attributes in Android xml files.

The product attribute was never used, except in one place in Chrome that
wasn't actually needed (see https://codereview.chromium.org/1288243002).
Further, the product attribute has no compelling use case in typical
development and isn't even documented on developer.android.com (See:
http://developer.android.com/guide/topics/resources/string-resource.html)

This also updates the header comment in android_xml.py to explain the
new <plurals> feature added in https://codereview.chromium.org/1258833004

R=thakis@chromium.org

Committed: https://code.google.com/p/grit-i18n/source/detail?r=195

[newt (away), 2015-08-13 21:02:25]

newt@chromium.org changed reviewers:
+ thakis@chromium.org

[newt (away), 2015-08-13 21:02:25]

PTAL

[Nico, 2015-08-13 22:21:27]

Is this a revert of some CL? If so, say what you're reverting?

https://codereview.chromium.org/1291173002/diff/1/grit/format/android_xml.py
File grit/format/android_xml.py (right):

https://codereview.chromium.org/1291173002/diff/1/grit/format/android_xml.py#...
grit/format/android_xml.py:47: in the output xml file. For example:
Huh, where's this coming from?

https://codereview.chromium.org/1291173002/diff/1/grit/format/android_xml.py#...
grit/format/android_xml.py:82: # Most strings are outputted as a <string>
element. Note the double quotes
s/outputted/output/

[newt (away), 2015-08-13 22:33:49]

On 2015/08/13 22:21:27, Nico (hiding) wrote:
> Is this a revert of some CL? If so, say what you're reverting?

No. This feature has been around since android_xml.py was added.
 
> https://codereview.chromium.org/1291173002/diff/1/grit/format/android_xml.py
> File grit/format/android_xml.py (right):
> 
>
https://codereview.chromium.org/1291173002/diff/1/grit/format/android_xml.py#...
> grit/format/android_xml.py:47: in the output xml file. For example:
> Huh, where's this coming from?
> 
>
https://codereview.chromium.org/1291173002/diff/1/grit/format/android_xml.py#...
> grit/format/android_xml.py:82: # Most strings are outputted as a <string>
> element. Note the double quotes
> s/outputted/output/

[newt (away), 2015-08-13 22:34:10]

https://codereview.chromium.org/1291173002/diff/1/grit/format/android_xml.py
File grit/format/android_xml.py (right):

https://codereview.chromium.org/1291173002/diff/1/grit/format/android_xml.py#...
grit/format/android_xml.py:47: in the output xml file. For example:
On 2015/08/13 22:21:27, Nico (hiding) wrote:
> Huh, where's this coming from?

I'm just updating the docs for a feature that was recently added in
https://codereview.chromium.org/1258833004

https://codereview.chromium.org/1291173002/diff/1/grit/format/android_xml.py#...
grit/format/android_xml.py:82: # Most strings are outputted as a <string>
element. Note the double quotes
On 2015/08/13 22:21:27, Nico (hiding) wrote:
> s/outputted/output/

Done.

[Nico, 2015-08-13 22:45:52]

lgtm, thanks!

https://codereview.chromium.org/1291173002/diff/20001/grit/format/android_xml.py
File grit/format/android_xml.py (right):

https://codereview.chromium.org/1291173002/diff/20001/grit/format/android_xml...
grit/format/android_xml.py:47: in the output xml file. For example:
Aha, then say in the Cl description something like "also document feature added
in $cl_link"

https://codereview.chromium.org/1291173002/diff/20001/grit/tool/android2grd.py
File grit/tool/android2grd.py (right):

https://codereview.chromium.org/1291173002/diff/20001/grit/tool/android2grd.p...
grit/tool/android2grd.py:247: print 'Error: string name contains illegal
characters: %s' % raw_name
> 80 cols

[newt (away), 2015-08-13 23:10:52]

https://codereview.chromium.org/1291173002/diff/20001/grit/tool/android2grd.py
File grit/tool/android2grd.py (right):

https://codereview.chromium.org/1291173002/diff/20001/grit/tool/android2grd.p...
grit/tool/android2grd.py:247: print 'Error: string name contains illegal
characters: %s' % raw_name
On 2015/08/13 22:45:51, Nico (hiding) wrote:
> > 80 cols

Done.

[newt (away), 2015-08-13 23:11:21]

Committed patchset #3 (id:40001) manually as 195 (presubmit successful).