Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(353)

Issue 1288243002: Remove unused "nosdcard" variants of several strings. (Closed)

Created:
5 years, 4 months ago by newt (away)
Modified:
5 years, 4 months ago
Reviewers:
boliu
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove unused "nosdcard" variants of several strings. We have several strings with two variants: default and nosdcard. At build time, grit dutifully converts these strings into Android resources like so: <message name="IDS_FOO_product_nosdcard">You have no SD card</message> <message name="IDS_FOO_product_default">You do have an SD card</message> becomes <string name="foo" product="nosdcard">You have no SD card</string> <string name="foo" product="default">You do have an SD card</string> However, aapt includes only one variant of the string in the APK, according to the value of the --product flag. Since we don't pass the --product flag to aapt, only the default strings get included in the APK. Hence the nosdcard variants are and have always been unused. Committed: https://crrev.com/223e74479dd3aef208716ba84d7e08d064396e6f Cr-Commit-Position: refs/heads/master@{#343148}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -12 lines) Patch
M chrome/android/java/strings/android_chrome_strings.grd View 2 chunks +3 lines, -12 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
newt (away)
PTAL, since you added these strings ages ago (as an intern!)
5 years, 4 months ago (2015-08-13 01:09:11 UTC) #2
boliu
On 2015/08/13 01:09:11, newt wrote: > PTAL, since you added these strings ages ago (as ...
5 years, 4 months ago (2015-08-13 01:12:41 UTC) #3
newt (away)
On 2015/08/13 01:12:41, boliu wrote: > On 2015/08/13 01:09:11, newt wrote: > > PTAL, since ...
5 years, 4 months ago (2015-08-13 01:18:12 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1288243002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1288243002/1
5 years, 4 months ago (2015-08-13 01:18:15 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-13 01:51:36 UTC) #7
commit-bot: I haz the power
5 years, 4 months ago (2015-08-13 01:52:18 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/223e74479dd3aef208716ba84d7e08d064396e6f
Cr-Commit-Position: refs/heads/master@{#343148}

Powered by Google App Engine
This is Rietveld 408576698