DescriptionRemove unused "nosdcard" variants of several strings.
We have several strings with two variants: default and nosdcard. At
build time, grit dutifully converts these strings into Android resources
like so:
<message name="IDS_FOO_product_nosdcard">You have no SD card</message>
<message name="IDS_FOO_product_default">You do have an SD card</message>
becomes
<string name="foo" product="nosdcard">You have no SD card</string>
<string name="foo" product="default">You do have an SD card</string>
However, aapt includes only one variant of the string in the APK,
according to the value of the --product flag. Since we don't pass the
--product flag to aapt, only the default strings get included in the
APK. Hence the nosdcard variants are and have always been unused.
Committed: https://crrev.com/223e74479dd3aef208716ba84d7e08d064396e6f
Cr-Commit-Position: refs/heads/master@{#343148}
Patch Set 1 #
Messages
Total messages: 8 (2 generated)
|