Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(368)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 129113002: Move GcmApi test cases into separate subdir in order to use RunExtensionTest (Closed)

Created:
6 years, 11 months ago by jianli
Modified:
6 years, 11 months ago
Reviewers:
fgorski
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Visibility:
Public.

Description

Move GcmApi test cases into separate subdir in order to use RunExtensionTest Change to use RunExtensionTest which is far less flaky than using RunExtensionSubtest BUG=177163 TEST=these are tests Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=243689

Patch Set 1 : Patch #

Unified diffs Side-by-side diffs Delta from patch set Stats (+257 lines, -276 lines) Patch
M chrome/browser/extensions/api/gcm/gcm_apitest.cc View 7 chunks +15 lines, -38 lines 0 comments Download
D chrome/test/data/extensions/api_test/gcm/functions/manifest.json View 1 chunk +0 lines, -8 lines 0 comments Download
D chrome/test/data/extensions/api_test/gcm/functions/register.html View 1 chunk +0 lines, -1 line 0 comments Download
D chrome/test/data/extensions/api_test/gcm/functions/register.js View 1 chunk +0 lines, -8 lines 0 comments Download
A + chrome/test/data/extensions/api_test/gcm/functions/register/manifest.json View 1 chunk +3 lines, -0 lines 0 comments Download
A chrome/test/data/extensions/api_test/gcm/functions/register/register.js View 1 chunk +12 lines, -0 lines 0 comments Download
D chrome/test/data/extensions/api_test/gcm/functions/register_validation.html View 1 chunk +0 lines, -1 line 0 comments Download
D chrome/test/data/extensions/api_test/gcm/functions/register_validation.js View 1 chunk +0 lines, -64 lines 0 comments Download
A + chrome/test/data/extensions/api_test/gcm/functions/register_validation/manifest.json View 1 chunk +3 lines, -0 lines 0 comments Download
A chrome/test/data/extensions/api_test/gcm/functions/register_validation/register_validation.js View 1 chunk +62 lines, -0 lines 0 comments Download
D chrome/test/data/extensions/api_test/gcm/functions/send.html View 1 chunk +0 lines, -1 line 0 comments Download
D chrome/test/data/extensions/api_test/gcm/functions/send.js View 1 chunk +0 lines, -137 lines 0 comments Download
A + chrome/test/data/extensions/api_test/gcm/functions/send/manifest.json View 1 chunk +3 lines, -0 lines 0 comments Download
A chrome/test/data/extensions/api_test/gcm/functions/send/send.js View 1 chunk +135 lines, -0 lines 0 comments Download
D chrome/test/data/extensions/api_test/gcm/functions/send_message_data.html View 1 chunk +0 lines, -1 line 0 comments Download
D chrome/test/data/extensions/api_test/gcm/functions/send_message_data.js View 1 chunk +0 lines, -17 lines 0 comments Download
A + chrome/test/data/extensions/api_test/gcm/functions/send_message_data/manifest.json View 1 chunk +3 lines, -0 lines 0 comments Download
A chrome/test/data/extensions/api_test/gcm/functions/send_message_data/send_message_data.js View 1 chunk +21 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
jianli
6 years, 11 months ago (2014-01-08 19:30:47 UTC) #1
jianli
6 years, 11 months ago (2014-01-08 19:36:58 UTC) #2
fgorski
lgtm
6 years, 11 months ago (2014-01-08 19:46:07 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jianli@chromium.org/129113002/90001
6 years, 11 months ago (2014-01-08 19:49:30 UTC) #4
commit-bot: I haz the power
6 years, 11 months ago (2014-01-08 23:15:20 UTC) #5
Message was sent while issue was closed. 
Change committed as 243689

Powered by Google App Engine
This is Rietveld 408576698