Move GcmApi test cases into separate subdir in order to use RunExtensionTest

chrome/browser/extensions/api/gcm/gcm_apitest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/run_loop.h"
 #include "chrome/browser/extensions/api/gcm/gcm_api.h"
 #include "chrome/browser/extensions/extension_apitest.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/services/gcm/fake_gcm_profile_service.h"
 #include "chrome/browser/services/gcm/gcm_profile_service_factory.h"
 #include "chrome/common/extensions/features/feature_channel.h"
 #include "chrome/test/base/ui_test_utils.h"
 
 namespace {
 
-const char kFunctionsTestExtension[] = "gcm/functions";
 const char kEventsExtension[] = "gcm/events";
 
 }  // namespace
 
 namespace extensions {
 
 class GcmApiTest : public ExtensionApiTest {
  public:
   GcmApiTest() : fake_gcm_profile_service_(NULL) {}
 
  protected:
+  virtual void SetUp() OVERRIDE;
   virtual void SetUpOnMainThread() OVERRIDE;
 
   void StartCollecting();
 
   const Extension* LoadTestExtension(const std::string& extension_path,
                                      const std::string& page_name);
 
-  void WaitUntilIdle();
-
   gcm::FakeGCMProfileService* service() const;
 
+ private:
   gcm::FakeGCMProfileService* fake_gcm_profile_service_;
 };
 
+void GcmApiTest::SetUp() {
+  // TODO(jianli): Once the GCM API enters stable, remove |channel|.
+  ScopedCurrentChannel channel(chrome::VersionInfo::CHANNEL_UNKNOWN);
+
+  ExtensionApiTest::SetUp();
+}
+
 void GcmApiTest::SetUpOnMainThread() {
   gcm::GCMProfileServiceFactory::GetInstance()->SetTestingFactory(
       browser()->profile(), &gcm::FakeGCMProfileService::Build);
   fake_gcm_profile_service_ = static_cast<gcm::FakeGCMProfileService*>(
       gcm::GCMProfileServiceFactory::GetInstance()->GetForProfile(
           browser()->profile()));
   gcm::FakeGCMProfileService::EnableGCMForTesting();
 }
 
 void GcmApiTest::StartCollecting() {
   service()->set_collect(true);
 }
 
-void GcmApiTest::WaitUntilIdle() {
-  base::RunLoop run_loop;
-  run_loop.RunUntilIdle();
-}
-
 gcm::FakeGCMProfileService* GcmApiTest::service() const {
   return fake_gcm_profile_service_;
 }
 
 const Extension* GcmApiTest::LoadTestExtension(
     const std::string& extension_path,
     const std::string& page_name) {
-  // TODO(jianli): Once the GCM API enters stable, remove |channel|.
-  ScopedCurrentChannel channel(chrome::VersionInfo::CHANNEL_UNKNOWN);
   const Extension* extension =
       LoadExtension(test_data_dir_.AppendASCII(extension_path));
   if (extension) {
     ui_test_utils::NavigateToURL(
         browser(), extension->GetResourceURL(page_name));
   }
   return extension;
 }
 
-// http://crbug.com/177163
-#if defined(OS_WIN)
-#define MAYBE_RegisterValidation DISABLED_RegisterValidation
-#else
-#define MAYBE_RegisterValidation RegisterValidation
-#endif
-IN_PROC_BROWSER_TEST_F(GcmApiTest, MAYBE_RegisterValidation) {
-  EXPECT_TRUE(RunExtensionSubtest(kFunctionsTestExtension,
-                                  "register_validation.html"));
+IN_PROC_BROWSER_TEST_F(GcmApiTest, RegisterValidation) {
+  ASSERT_TRUE(RunExtensionTest("gcm/functions/register_validation"));
 }
 
 IN_PROC_BROWSER_TEST_F(GcmApiTest, Register) {
   StartCollecting();
-  const extensions::Extension* extension =
-      LoadTestExtension(kFunctionsTestExtension, "register.html");
-  ASSERT_TRUE(extension);
+  ASSERT_TRUE(RunExtensionTest("gcm/functions/register"));
 
-  WaitUntilIdle();
-
-  EXPECT_EQ(extension->id(), service()->last_registered_app_id());
   // SHA1 of the public key provided in manifest.json.
   EXPECT_EQ("26469186F238EE08FA71C38311C6990F61D40DCA",
             service()->last_registered_cert());
   const std::vector<std::string>& sender_ids =
       service()->last_registered_sender_ids();
   EXPECT_TRUE(std::find(sender_ids.begin(), sender_ids.end(), "Sender1") !=
                   sender_ids.end());
   EXPECT_TRUE(std::find(sender_ids.begin(), sender_ids.end(), "Sender2") !=
                   sender_ids.end());
 }
 
-// http://crbug.com/177163
-#if defined(OS_WIN)
-#define MAYBE_SendValidation DISABLED_SendValidation
-#else
-#define MAYBE_SendValidation SendValidation
-#endif
-IN_PROC_BROWSER_TEST_F(GcmApiTest, MAYBE_SendValidation) {
-  EXPECT_TRUE(RunExtensionSubtest(kFunctionsTestExtension, "send.html"));
+IN_PROC_BROWSER_TEST_F(GcmApiTest, SendValidation) {
+  ASSERT_TRUE(RunExtensionTest("gcm/functions/send"));
 }
 
 IN_PROC_BROWSER_TEST_F(GcmApiTest, SendMessageData) {
   StartCollecting();
-  const extensions::Extension* extension =
-      LoadTestExtension(kFunctionsTestExtension, "send_message_data.html");
-  ASSERT_TRUE(extension);
-
-  WaitUntilIdle();
+  ASSERT_TRUE(RunExtensionTest("gcm/functions/send_message_data"));
 
   EXPECT_EQ("destination-id", service()->last_receiver_id());
   const gcm::GCMClient::OutgoingMessage& message =
       service()->last_sent_message();
   gcm::GCMClient::MessageData::const_iterator iter;
 
   EXPECT_TRUE((iter = message.data.find("key1")) != message.data.end());
   EXPECT_EQ("value1", iter->second);
 
   EXPECT_TRUE((iter = message.data.find("key2")) != message.data.end());
@@ skipping 48 matching lines @@
       gcm::GCMClient::NETWORK_ERROR);
   router.OnSendError(extension->id(), "error_message_4",
       gcm::GCMClient::UNKNOWN_ERROR);
   router.OnSendError(extension->id(), "error_message_5",
       gcm::GCMClient::TTL_EXCEEDED);
 
   EXPECT_TRUE(catcher.GetNextResult()) << catcher.message();
 }
 
 }  // namespace extensions