Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(578)

Issue 1291123002: CFI Linux CF: Add flags for better stack traces. (Closed)

Created:
5 years, 4 months ago by pcc1
Modified:
5 years, 4 months ago
Reviewers:
M-A Ruel, inferno
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/tools/build.git@master
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

CFI Linux CF: Add flags for better stack traces. Based on https://codereview.chromium.org/1289673002 and the 'ASAN Release (symbolized)' config in masters/master.chromium.lkgr/master_lkgr_cfg.py. The former will be partially reverted once this lands in order to prevent the flags from interfering with regular perf measurements. BUG=464797 R=maruel@chromium.org TBR=inferno@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=296303

Patch Set 1 #

Total comments: 2

Patch Set 2 : Address comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M masters/master.chromium.fyi/master.cfg View 1 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 9 (2 generated)
pcc1
5 years, 4 months ago (2015-08-13 20:02:16 UTC) #1
inferno
https://codereview.chromium.org/1291123002/diff/1/masters/master.chromium.fyi/master.cfg File masters/master.chromium.fyi/master.cfg (right): https://codereview.chromium.org/1291123002/diff/1/masters/master.chromium.fyi/master.cfg#newcode1796 masters/master.chromium.fyi/master.cfg:1796: '-fno-inline-function -fno-inline -fno-omit-frame-pointer ' 1. typo -fno-inline-functions 2. -gline-tables-only ...
5 years, 4 months ago (2015-08-13 20:03:58 UTC) #2
M-A Ruel
rubberstamp lgtm
5 years, 4 months ago (2015-08-13 20:08:23 UTC) #3
pcc1
https://codereview.chromium.org/1291123002/diff/1/masters/master.chromium.fyi/master.cfg File masters/master.chromium.fyi/master.cfg (right): https://codereview.chromium.org/1291123002/diff/1/masters/master.chromium.fyi/master.cfg#newcode1796 masters/master.chromium.fyi/master.cfg:1796: '-fno-inline-function -fno-inline -fno-omit-frame-pointer ' On 2015/08/13 20:03:58, inferno wrote: ...
5 years, 4 months ago (2015-08-13 20:13:44 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1291123002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1291123002/20001
5 years, 4 months ago (2015-08-13 20:14:38 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001) as http://src.chromium.org/viewvc/chrome?view=rev&revision=296303
5 years, 4 months ago (2015-08-13 20:17:09 UTC) #8
inferno
5 years, 4 months ago (2015-08-13 20:25:13 UTC) #9
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698