build: Enable flags for better stack traces in non-official CFI builds.

build: Enable flags for better stack traces in non-official CFI builds.

BUG=464797
R=inferno@chromium.org
TBR=thakis@chromium.org

Committed: https://crrev.com/c964309764aeedac75ce8bcd11d59dd1f827484a
Cr-Commit-Position: refs/heads/master@{#342952}

[Nico, 2015-08-11 22:44:41]

Do you need to change any .gn files?

https://codereview.chromium.org/1289673002/diff/1/build/common.gypi
File build/common.gypi (right):

https://codereview.chromium.org/1289673002/diff/1/build/common.gypi#newcode4388
build/common.gypi:4388: '(cfi_vptr==1 and buildtype!="Official")', {
Why is this keyed off buildtype==Official while all the rest now uses cfi_diag?
When do I use which?

[inferno, 2015-08-11 22:52:56]

On 2015/08/11 22:44:41, Nico (hiding) wrote:
> Do you need to change any .gn files?

Yes right,
https://code.google.com/p/chromium/codesearch#chromium/src/build/config/compi....
Although i don't think any of the sanitizer bots are using gn, but always we
should fix gn for future.

> 
> https://codereview.chromium.org/1289673002/diff/1/build/common.gypi
> File build/common.gypi (right):
> 
>
https://codereview.chromium.org/1289673002/diff/1/build/common.gypi#newcode4388
> build/common.gypi:4388: '(cfi_vptr==1 and buildtype!="Official")', {
> Why is this keyed off buildtype==Official while all the rest now uses
cfi_diag?
> When do I use which?

[pcc1, 2015-08-11 22:55:00]

On 2015/08/11 22:52:56, inferno wrote:
> On 2015/08/11 22:44:41, Nico (hiding) wrote:
> > Do you need to change any .gn files?
> 
> Yes right,
>
https://code.google.com/p/chromium/codesearch#chromium/src/build/config/compi....
> Although i don't think any of the sanitizer bots are using gn, but always we
> should fix gn for future.

When I port cfi config to gn (not done yet), this will happen.

[pcc1, 2015-08-11 22:55:10]

https://codereview.chromium.org/1289673002/diff/1/build/common.gypi
File build/common.gypi (right):

https://codereview.chromium.org/1289673002/diff/1/build/common.gypi#newcode4388
build/common.gypi:4388: '(cfi_vptr==1 and buildtype!="Official")', {
On 2015/08/11 22:44:40, Nico (hiding) wrote:
> Why is this keyed off buildtype==Official while all the rest now uses
cfi_diag?
> When do I use which?

We only emit stack traces in release mode when cfi_vptr=1 cfi_diag=0
buildtype!="Official" (see e.g.
https://code.google.com/p/chromium/codesearch#chromium/src/content/renderer/r...);
this simply matches that logic. (I guess we could also test for cfi_diag here,
but these particular flags don't matter as much in cfi_diag mode).

[Nico, 2015-08-11 23:12:46]

lgtm ¯\(°_o)/¯

[pcc1, 2015-08-11 23:14:56]

The CQ bit was checked by pcc@chromium.org

[commit-bot: I haz the power, 2015-08-11 23:15:05]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1289673002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1289673002/1

[commit-bot: I haz the power, 2015-08-12 01:02:33]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-08-12 01:03:09]

Patchset 1 (id:??) landed as
https://crrev.com/c964309764aeedac75ce8bcd11d59dd1f827484a
Cr-Commit-Position: refs/heads/master@{#342952}