Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Issue 1291113003: [turbofan] Support unboxed float and double stack parameters and add tests. (Closed)

Created:
5 years, 4 months ago by titzer
Modified:
5 years, 4 months ago
Reviewers:
Jarin
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Support unboxed float and double stack parameters and add tests. R=jarin@chromium.org BUG= Committed: https://crrev.com/0492bb3291c838d7e11261abc32af58bed58bcf0 Cr-Commit-Position: refs/heads/master@{#30203}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+190 lines, -107 lines) Patch
M src/compiler/arm/code-generator-arm.cc View 1 chunk +6 lines, -1 line 0 comments Download
M src/compiler/arm/instruction-selector-arm.cc View 1 2 chunks +10 lines, -8 lines 0 comments Download
M src/compiler/ia32/code-generator-ia32.cc View 1 chunk +4 lines, -1 line 0 comments Download
M src/compiler/ia32/instruction-selector-ia32.cc View 1 2 chunks +14 lines, -12 lines 0 comments Download
M src/compiler/mips/code-generator-mips.cc View 1 chunk +11 lines, -2 lines 0 comments Download
M src/compiler/mips/instruction-selector-mips.cc View 1 2 chunks +12 lines, -12 lines 0 comments Download
M src/compiler/mips64/code-generator-mips64.cc View 6 chunks +14 lines, -11 lines 0 comments Download
M src/compiler/mips64/instruction-selector-mips64.cc View 1 2 chunks +10 lines, -10 lines 0 comments Download
M src/compiler/ppc/code-generator-ppc.cc View 2 chunks +10 lines, -2 lines 0 comments Download
M src/compiler/ppc/instruction-selector-ppc.cc View 1 2 chunks +9 lines, -6 lines 0 comments Download
M src/compiler/x64/instruction-selector-x64.cc View 1 2 chunks +12 lines, -11 lines 0 comments Download
M src/compiler/x87/instruction-selector-x87.cc View 1 2 chunks +12 lines, -11 lines 0 comments Download
M test/cctest/compiler/test-run-native-calls.cc View 8 chunks +66 lines, -20 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
titzer
PTAL: small tweaks to code generators and instruction selectors to handle float32/float64 passed on the ...
5 years, 4 months ago (2015-08-17 13:24:47 UTC) #1
Jarin
lgtm. However, I am not a big fan of the 'if (Node* node = ...)' ...
5 years, 4 months ago (2015-08-17 14:01:56 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1291113003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1291113003/20001
5 years, 4 months ago (2015-08-17 17:33:56 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 4 months ago (2015-08-17 17:35:44 UTC) #6
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/0492bb3291c838d7e11261abc32af58bed58bcf0 Cr-Commit-Position: refs/heads/master@{#30203}
5 years, 4 months ago (2015-08-17 17:36:02 UTC) #7
titzer
5 years, 4 months ago (2015-08-17 17:58:44 UTC) #8
Message was sent while issue was closed.
On 2015/08/17 14:01:56, Jarin wrote:
> lgtm.
> 
> However, I am not a big fan of the 'if (Node* node = ...)' pattern, especially
> when there is a 'node' variable in the outer scope, so it can be easily
misread
> as if (node == ...)'.

I fixed the shadowing of the variable in the outer scope.

Powered by Google App Engine
This is Rietveld 408576698