Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(139)

Unified Diff: src/compiler/mips64/instruction-selector-mips64.cc

Issue 1291113003: [turbofan] Support unboxed float and double stack parameters and add tests. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/compiler/mips64/code-generator-mips64.cc ('k') | src/compiler/ppc/code-generator-ppc.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/compiler/mips64/instruction-selector-mips64.cc
diff --git a/src/compiler/mips64/instruction-selector-mips64.cc b/src/compiler/mips64/instruction-selector-mips64.cc
index e4d8795f1b1716b99dbf385c2c9cb4b5f3d1a794..33d6f58c28bdfc205e4333690585041424049e2a 100644
--- a/src/compiler/mips64/instruction-selector-mips64.cc
+++ b/src/compiler/mips64/instruction-selector-mips64.cc
@@ -682,22 +682,22 @@ void InstructionSelector::VisitCall(Node* node, BasicBlock* handler) {
// Poke any stack arguments.
int slot = kCArgSlotCount;
- for (Node* node : buffer.pushed_nodes) {
- Emit(kMips64StoreToStackSlot, g.NoOutput(), g.UseRegister(node),
+ for (Node* input : buffer.pushed_nodes) {
+ Emit(kMips64StoreToStackSlot, g.NoOutput(), g.UseRegister(input),
g.TempImmediate(slot << kPointerSizeLog2));
++slot;
}
} else {
- const int32_t push_count = static_cast<int32_t>(buffer.pushed_nodes.size());
+ int push_count = static_cast<int>(descriptor->StackParameterCount());
if (push_count > 0) {
Emit(kMips64StackClaim, g.NoOutput(),
g.TempImmediate(push_count << kPointerSizeLog2));
}
- int32_t slot = push_count - 1;
- for (Node* node : base::Reversed(buffer.pushed_nodes)) {
- Emit(kMips64StoreToStackSlot, g.NoOutput(), g.UseRegister(node),
- g.TempImmediate(slot << kPointerSizeLog2));
- slot--;
+ for (size_t n = 0; n < buffer.pushed_nodes.size(); ++n) {
+ if (Node* input = buffer.pushed_nodes[n]) {
+ Emit(kMips64StoreToStackSlot, g.NoOutput(), g.UseRegister(input),
+ g.TempImmediate(static_cast<int>(n << kPointerSizeLog2)));
+ }
}
}
@@ -791,8 +791,8 @@ void InstructionSelector::VisitTailCall(Node* node) {
g.TempImmediate(push_count << kPointerSizeLog2));
}
int slot = push_count - 1;
- for (Node* node : base::Reversed(buffer.pushed_nodes)) {
- Emit(kMips64StoreToStackSlot, g.NoOutput(), g.UseRegister(node),
+ for (Node* input : base::Reversed(buffer.pushed_nodes)) {
+ Emit(kMips64StoreToStackSlot, g.NoOutput(), g.UseRegister(input),
g.TempImmediate(slot << kPointerSizeLog2));
slot--;
}
« no previous file with comments | « src/compiler/mips64/code-generator-mips64.cc ('k') | src/compiler/ppc/code-generator-ppc.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698