Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(403)

Issue 1290743005: Make some foo.h headers usable without foo-inl.h header. (Closed)

Created:
5 years, 4 months ago by Michael Starzinger
Modified:
5 years, 4 months ago
Reviewers:
rossberg
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Make some foo.h headers usable without foo-inl.h header. This CL us a pure refactoring that makes an empty compilation unit including just "foo.h" but not "foo-inl.h" compile without warnings or errors. This is needed to further reduce the header dependency tangle. R=rossberg@chromium.org Committed: https://crrev.com/8e634eaa0b9e4441b98e4c53f06f4a17af9470a8 Cr-Commit-Position: refs/heads/master@{#30158}

Patch Set 1 #

Patch Set 2 : As per offline comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+85 lines, -79 lines) Patch
M src/conversions.h View 2 chunks +11 lines, -59 lines 0 comments Download
M src/conversions-inl.h View 2 chunks +63 lines, -0 lines 0 comments Download
M src/layout-descriptor.h View 1 chunk +1 line, -3 lines 0 comments Download
M src/layout-descriptor-inl.h View 1 chunk +5 lines, -0 lines 0 comments Download
M src/types.h View 1 3 chunks +5 lines, -3 lines 0 comments Download
M src/types-inl.h View 1 2 chunks +0 lines, -14 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Michael Starzinger
5 years, 4 months ago (2015-08-13 13:29:52 UTC) #1
rossberg
lgtm
5 years, 4 months ago (2015-08-13 13:32:47 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1290743005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1290743005/20001
5 years, 4 months ago (2015-08-13 13:47:21 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 4 months ago (2015-08-13 14:02:27 UTC) #6
commit-bot: I haz the power
5 years, 4 months ago (2015-08-13 14:02:43 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/8e634eaa0b9e4441b98e4c53f06f4a17af9470a8
Cr-Commit-Position: refs/heads/master@{#30158}

Powered by Google App Engine
This is Rietveld 408576698