Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1621)

Unified Diff: src/types.h

Issue 1290743005: Make some foo.h headers usable without foo-inl.h header. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: As per offline comment. Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/layout-descriptor-inl.h ('k') | src/types-inl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/types.h
diff --git a/src/types.h b/src/types.h
index 8d63908015db675fca8c0d8d46428808ad2ee14d..31ee95cbb46069b21cf7e0764bebc21c9c74459d 100644
--- a/src/types.h
+++ b/src/types.h
@@ -6,8 +6,8 @@
#define V8_TYPES_H_
#include "src/conversions.h"
-#include "src/factory.h"
#include "src/handles.h"
+#include "src/objects.h"
#include "src/ostreams.h"
namespace v8 {
@@ -1003,7 +1003,7 @@ struct ZoneTypeConfig {
static const int kRangeStructTag = 0x1000;
- template<class T> static inline T* null_handle();
+ template<class T> static inline T* null_handle() { return nullptr; }
template<class T> static inline T* handle(T* type);
template<class T> static inline T* cast(Type* type);
@@ -1058,7 +1058,9 @@ struct HeapTypeConfig {
static const int kRangeStructTag = 0xffff;
- template<class T> static inline i::Handle<T> null_handle();
+ template<class T> static inline i::Handle<T> null_handle() {
+ return i::Handle<T>();
+ }
template<class T> static inline i::Handle<T> handle(T* type);
template<class T> static inline i::Handle<T> cast(i::Handle<Type> type);
« no previous file with comments | « src/layout-descriptor-inl.h ('k') | src/types-inl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698